[18.0][IMP] pos_config_logo: support custom logo in POS navbar and saver screen#1546
Open
MiguelMachadoM wants to merge 1 commit into
Open
[18.0][IMP] pos_config_logo: support custom logo in POS navbar and saver screen#1546MiguelMachadoM wants to merge 1 commit into
MiguelMachadoM wants to merge 1 commit into
Conversation
…reen Extend pos_config_logo to reuse the configured POS logo beyond receipts, showing it in the navbar and saver screen, and document the new behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Hello, thanks for the pr ! Does it superseed #1543 ? |
Member
|
Please remove the second commit. The module version bump is done on merge automatically by bots. |
Member
|
You have added a third commit instead of removing the second one. Please remove both or squash them into one. |
0931085 to
d156581
Compare
Member
|
I have been able to push it the unique commit to your branch through GitHub mechanisms. |
pedrobaeza
approved these changes
May 7, 2026
Member
pedrobaeza
left a comment
There was a problem hiding this comment.
Tested and working properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends
pos_config_logoso the POS configuration logo is used not only in the receipt header, but also in:What was changed
Navbar(posHeaderLogoSrc)SaverScreen(saverLogoSrc)Functional impact
When a logo is configured in POS settings (Alternative point of sale logo), the same logo is now consistently shown in receipt, navbar, and saver screen.
Notes