Skip to content

[18.0][FIX] pos_margin: Remove margin data on the ticket#1549

Merged
OCA-git-bot merged 1 commit into
OCA:18.0from
Tecnativa:18.0-imp-pos_margin-TT62342
May 11, 2026
Merged

[18.0][FIX] pos_margin: Remove margin data on the ticket#1549
OCA-git-bot merged 1 commit into
OCA:18.0from
Tecnativa:18.0-imp-pos_margin-TT62342

Conversation

@victoralmau
Copy link
Copy Markdown
Member

@victoralmau victoralmau commented May 8, 2026 •
edited
Loading

Remove margin data on the ticket

Before
antes

After
despues

Please @pedrobaeza can you review it?

@Tecnativa TT62342

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 8, 2026

Hi @legalsylvain,
some modules you are maintaining are being modified, check this out!

pedrobaeza
pedrobaeza approved these changes May 8, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it shouldn't be the default.

legalsylvain
legalsylvain requested changes May 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont understand why you talk about ticket. The module display margin in front end ui afaik, not in tickets.

@victoralmau victoralmau force-pushed the 18.0-imp-pos_margin-TT62342 branch from c27526f to b25364a Compare May 11, 2026 08:02
@victoralmau victoralmau changed the title [18.0][IMP] pos_margin: Remove the default value for the iface_display_margin field to prevent the margin from being displayed on tickets [18.0][FIX] pos_margin: Remove margin data on the ticket May 11, 2026
@victoralmau victoralmau marked this pull request as draft May 11, 2026 08:03
@CarlosRoca13 CarlosRoca13 force-pushed the 18.0-imp-pos_margin-TT62342 branch from b25364a to cc382ba Compare May 11, 2026 09:31
@victoralmau victoralmau marked this pull request as ready for review May 11, 2026 09:35
@victoralmau
Copy link
Copy Markdown
Member Author

victoralmau commented May 11, 2026

I dont understand why you talk about ticket. The module display margin in front end ui afaik, not in tickets.

Sorry for the confusion, the default setting wasn't the issue; the margin was being displayed in the tickets (both the total and the individual lines). I've added some screenshots to the PR description to help clarify what was happening.

@pedrobaeza pedrobaeza added this to the 18.0 milestone May 11, 2026
@legalsylvain
Copy link
Copy Markdown
Contributor

legalsylvain commented May 11, 2026

Thanks !

/ocabot merge minor

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 11, 2026

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-1549-by-legalsylvain-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b4f88ce into OCA:18.0 May 11, 2026
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 11, 2026

Congratulations, your PR was merged at 1c6d6d8. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 18.0-imp-pos_margin-TT62342 branch May 11, 2026 11:10
@victoralmau victoralmau mentioned this pull request May 11, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legalsylvain legalsylvain legalsylvain requested changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

+1 more reviewer

@CarlosRoca13 CarlosRoca13 CarlosRoca13 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merged 🎉 mod:pos_margin Module pos_margin series:18.0

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

5 participants

@victoralmau @OCA-git-bot @legalsylvain @pedrobaeza @CarlosRoca13