[MIG][16.0] product total weight from packaging#1221
Conversation
glitchov
force-pushed
the
16.0-mig-product_total_weight_from_packaging
branch
2 times, most recently
from
ccbd12e to
0ae6102
Compare
xavier-bouquiaux
left a comment
xavier-bouquiaux
left a comment
There was a problem hiding this comment.
LGTM technical side
There was a problem hiding this comment.
The max_weight is a concept that was introduced in odoo delivery module to define the transporter weight limit for the shipped packaging. Before v16, the transporter packaging and product packaging was the same model product.packaging. Now the transporter packaging is moved to the model stock.package.type.
In v13, max_weight defined in delivery module on product.packaging was used also for product packaging dimension.
In v14, the weight field was added on the product.packaging and the max_weight was still coming from delivery module. This was introducing inconsistency as some modules migrated from v13 to v14 still rely on max_weight and some rely on the new weight field.
In v16, we have to drop this max_weight on product.packaging as the delivery module moved it to stock.package.type and we should rely only on the weight field.
The migration of the product_packaging_dimension #1161 has to be fixed to not expose the old max_weight field and any data on max_weight must be moved to weight if empty.
This module also deserves a big warning that it is lacking the weight uom conversions as it depends on product_packaging_dimension that depends on product_logistics_uom that allows to set a uom on the weight. The sum in this module is assuming all weights are in kg
|
Hello @glitchov , there are conflicts with the branch 16.0, by any chance could you have a look at it and maybe perform a rebase? |
lmignon
force-pushed
the
16.0-mig-product_total_weight_from_packaging
branch
from
2a63fdc to
399adb0
Compare
|
@leemannd @victorvermot This branch is now rebased and comments from @jbaudoux are included |
jbaudoux
left a comment
jbaudoux
left a comment
There was a problem hiding this comment.
Thanks @lmignon for the update.
Not related to the migration but this module still deserves a big warning that it is lacking the weight uom conversions as it depends on product_packaging_dimension that depends on product_logistics_uom that allows to set a uom on the weight. The sum in this module is assuming all weights are in kg
|
@jbaudoux Warning added... |
lmignon
force-pushed
the
16.0-mig-product_total_weight_from_packaging
branch
from
ea04aa5 to
e3ebe65
Compare
…x_weight The max_weight is a concept that was introduced in odoo delivery module to define the transporter weight limit for the shipped packaging. Before v16, the transporter packaging and product packaging was the same model product.packaging. Now the transporter packaging is moved to the model stock.package.type. In v13, max_weight defined in delivery module on product.packaging was used also for product packaging dimension. In v14, the weight field was added on the product.packaging and the max_weight was still coming from delivery module. This was introducing inconsistency as some modules migrated from v13 to v14 still rely on max_weight and some rely on the new weight field. In v16, we have to drop this max_weight on product.packaging as the delivery module moved it to stock.package.type and we should rely only on the weight field. The migration of the product_packaging_dimension OCA#1161 has to be fixed to not expose the old max_weight field and any data on max_weight must be moved to weight if empty. This module also deserves a big warning that it is lacking the weight uom conversions as it depends on product_packaging_dimension that depends on product_logistics_uom that allows to set a uom on the weight. The sum in this module is assuming all weights are in kg Co-authored-by: Jacques-Etienne Baudoux <je@bcim.be>
glitchov
force-pushed
the
16.0-mig-product_total_weight_from_packaging
branch
from
e3ebe65 to
637765a
Compare
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 258d5ac. Thanks a lot for contributing to OCA. ❤️ |
9 participants
Migration from 14.0