[19.0][MIG] product_pricelist_revision: Migration to 19.0 by BhaveshHeliconia · Pull Request #2100 · OCA/product-attribute

BhaveshHeliconia · 2025-10-15T07:33:20Z

No description provided.

rousseldenis · 2025-10-15T11:06:29Z

/ocabot migration product_pricelist_revision

gdgellatly

Functional test on own db plus code review LGTM.

gdgellatly

Sorry I put review against wrong module. I now tested this one on live database and it didn't work. It duplicated the item just fine but did not take the variance. Will get back to tomorrow.

[UPD] Update product_pricelist_revision.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-12.0/product-attribute-12.0-product_pricelist_revision Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_pricelist_revision/

…t filter TT28144 [UPD] Update product_pricelist_revision.pot

Currently translated at 100.0% (30 of 30 strings) Translation: product-attribute-13.0/product-attribute-13.0-product_pricelist_revision Translate-URL: https://translation.odoo-community.org/projects/product-attribute-13-0/product-attribute-13-0-product_pricelist_revision/ca/

Before this change on runbot we caught a Warning about deprecated call to decimal_precision.get_precision(<application>) [UPD] README.rst product_pricelist_revision 13.0.1.1.0

TT27524

Fix website key in the manifests

TT31815

Currently translated at 31.0% (9 of 29 strings) Translation: product-attribute-14.0/product-attribute-14.0-product_pricelist_revision Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_pricelist_revision/it/

Currently translated at 100.0% (29 of 29 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_revision Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_revision/it/

- Include context keys for avoiding mail operations overhead.

Currently translated at 100.0% (29 of 29 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_revision Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_revision/fr/

BhaveshHeliconia · 2026-03-06T08:52:44Z

Sorry I put review against wrong module. I now tested this one on live database and it didn't work. It duplicated the item just fine but did not take the variance. Will get back to tomorrow.

Hi @gdgellatly,

I have tested this module locally and on Runbot, and it is working as expected.

Please note that this module's duplicate wizard only works with fixed price items (compute_price = 'fixed'). It does not apply the variance for other pricing types such as formula or percentage/discount. The wizard view also mentions this:

"Note: Only works with fixed price items. The variation % will be applied to calculate the new price."

If you are facing any issue specifically with fixed price items, could you please elaborate on the steps to reproduce and where exactly you are getting stuck? That would help us investigate further.

gdgellatly · 2026-03-08T20:00:34Z

Sorry I put review against wrong module. I now tested this one on live database and it didn't work. It duplicated the item just fine but did not take the variance. Will get back to tomorrow.

Hi @gdgellatly,

I have tested this module locally and on Runbot, and it is working as expected.

Please note that this module's duplicate wizard only works with fixed price items (compute_price = 'fixed'). It does not apply the variance for other pricing types such as formula or percentage/discount. The wizard view also mentions this:

"Note: Only works with fixed price items. The variation % will be applied to calculate the new price."

If you are facing any issue specifically with fixed price items, could you please elaborate on the steps to reproduce and where exactly you are getting stuck? That would help us investigate further.

Hi @BhaveshHeliconia, yes sorry we worked that out and deleted the module. We have no use case for it so will remove my review. EDIT: I no longr have access to remove reviews so we will just have to live with it, it did work, just not how expected.

CarlosRoca13

Please add this change: #2291

…test Odoo 18 enforces a strict date_end > date_start constraint on pricelist items. The test was using the same datetime for both fields, causing a ValidationError. See https://github.com/odoo/odoo/blob/36a7cadbfb9007ebddd660b7709e4bef58e96c2d/addons/product/models/product_pricelist_item.py#L307

BhaveshHeliconia · 2026-05-08T07:51:24Z

Please add this change: #2291

Done, thanks!

pedrobaeza · 2026-05-08T10:29:51Z

/ocabot merge nobump

OCA-git-bot · 2026-05-08T10:30:01Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 19.0-ocabot-merge-pr-2100-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2026-05-08T10:34:48Z

Congratulations, your PR was merged at 3ae2dd5. Thanks a lot for contributing to OCA. ❤️

BhaveshHeliconia mentioned this pull request Oct 15, 2025

Migration to version 19.0 #2075

Open

73 tasks

rousseldenis added needs review migration labels Oct 15, 2025

OCA-git-bot added this to the 19.0 milestone Oct 15, 2025

gdgellatly approved these changes Mar 3, 2026

View reviewed changes

gdgellatly reviewed Mar 3, 2026

View reviewed changes

sergio-teruel and others added 23 commits March 6, 2026 14:12

11.0[WIP]product_pricelist_revision

1d6f78f

[11.0][IMP] product_pricelist_revision: Complete translations

08a2e08

[IMP] product_pricelist_revision: black, isort

933b112

[MIG] product_pricelist_revision: Migration to v13.0

64dabab

[IMP] product_pricelist_revision: Add percent price column and curren…

81a175c

…t filter TT28144 [UPD] Update product_pricelist_revision.pot

Added translation using Weblate (Catalan)

e856d58

[FIX] product_pricelist_revision: Applied the new way for digits

f025ba2

Before this change on runbot we caught a Warning about deprecated call to decimal_precision.get_precision(<application>) [UPD] README.rst product_pricelist_revision 13.0.1.1.0

[IMP] product_pricelist_revision: Allow create pricelist item

894cd73

TT27524

[IMP] *: pre-commit execution

e77a1cd

Fix website key in the manifests

[MIG] product_pricelist_revision: Migration to 14.0

2120bbd

TT31815

[FIX] Fix access right issues when using actions

f947f3d

product_pricelist_revision: fix date_end/date_start are datetime

0710a29

Added translation using Weblate (Italian)

cc748f0

[MIG] product_pricelist_revision: Migration to 15.0

85ca50a

[MIG] product_pricelist_revision: Migration to 16.0

935fb51

[IMP] product_pricelist_revision: test performance improvement

ab6826e

- Include context keys for avoiding mail operations overhead.

Added translation using Weblate (French)

f4f1174

[IMP] product_pricelist_revision: pre-commit auto fixes

b0be557

mario and others added 4 commits March 6, 2026 14:12

[MIG] product_pricelist_revision: Migration to 17.0

67c94d5

[MIG] product_pricelist_revision: Migration to 18.0

89bda76

[UPD] Update product_pricelist_revision.pot

ff3eb80

[BOT] post-merge updates

a841c48

BhaveshHeliconia force-pushed the 19.0-mig-product_pricelist_revision branch from 1b96722 to 68cfb1b Compare March 6, 2026 08:42

Murtaza-OSI approved these changes Mar 16, 2026

View reviewed changes

OCA-git-bot added the approved label Mar 16, 2026

CarlosRoca13 reviewed May 8, 2026

View reviewed changes

CarlosRoca13 and others added 2 commits May 8, 2026 13:06

[MIG] product_pricelist_revision: Migration to 19.0

76d44c4

BhaveshHeliconia force-pushed the 19.0-mig-product_pricelist_revision branch from 68cfb1b to 76d44c4 Compare May 8, 2026 07:46

OCA-git-bot added series:19.0 mod:product_pricelist_revision Module product_pricelist_revision labels May 8, 2026

CarlosRoca13 approved these changes May 8, 2026

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label May 8, 2026

OCA-git-bot merged commit 1345655 into OCA:19.0 May 8, 2026
5 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels May 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[19.0][MIG] product_pricelist_revision: Migration to 19.0#2100

[19.0][MIG] product_pricelist_revision: Migration to 19.0#2100
OCA-git-bot merged 29 commits into
OCA:19.0from
HeliconiaIO:19.0-mig-product_pricelist_revision

BhaveshHeliconia commented Oct 15, 2025

Uh oh!

rousseldenis commented Oct 15, 2025

Uh oh!

gdgellatly left a comment

Uh oh!

gdgellatly left a comment

Uh oh!

BhaveshHeliconia commented Mar 6, 2026

Uh oh!

gdgellatly commented Mar 8, 2026 •

edited

Loading

Uh oh!

CarlosRoca13 left a comment

Uh oh!

BhaveshHeliconia commented May 8, 2026

Uh oh!

pedrobaeza commented May 8, 2026

Uh oh!

OCA-git-bot commented May 8, 2026

Uh oh!

Uh oh!

OCA-git-bot commented May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

Uh oh!

Conversation

BhaveshHeliconia commented Oct 15, 2025

Uh oh!

rousseldenis commented Oct 15, 2025

Uh oh!

gdgellatly left a comment

Choose a reason for hiding this comment

Uh oh!

gdgellatly left a comment

Choose a reason for hiding this comment

Uh oh!

BhaveshHeliconia commented Mar 6, 2026

Uh oh!

gdgellatly commented Mar 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CarlosRoca13 left a comment

Choose a reason for hiding this comment

Uh oh!

BhaveshHeliconia commented May 8, 2026

Uh oh!

pedrobaeza commented May 8, 2026

Uh oh!

OCA-git-bot commented May 8, 2026

Uh oh!

Uh oh!

OCA-git-bot commented May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

gdgellatly commented Mar 8, 2026 •

edited

Loading