[19.0][MIG] product_set: Migration to 19.0 by CRogos · Pull Request #2263 · OCA/product-attribute

CRogos · 2026-04-16T18:34:12Z

supersede: #2098

includes: #2201

Remove odoo_test_helper dependency — tests/models.py deleted
Convert product.set.wizard from AbstractModel to TransientModel
Fix test_product_set.py — replace all demo data env.ref() with programmatic record creation (including base.res_partner_1)
Fix test_product_set_line.py — UoM refs retained (module data, always available)
Fix test_product_set_wizard.py — fully programmatic, no demo refs

@Saran440, @rousseldenis. @mmrondon Could you please review?
There were a few (breaking) changes necessary. Could you have a close look on the changes and test.

[UPD] Update product_set.pot [UPD] README.rst Translated using Weblate (Spanish) Currently translated at 100.0% (23 of 23 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_set/es/ [UPD] README.rst Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (23 of 23 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_set/pt_BR/ Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-16.0/product-attribute-16.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_set/ Translated using Weblate (Italian) Currently translated at 100.0% (23 of 23 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_set/it/

[UPD] Update product_set.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-16.0/product-attribute-16.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_set/ Translated using Weblate (Spanish) Currently translated at 100.0% (29 of 29 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_set/es/ Translated using Weblate (Italian) Currently translated at 100.0% (29 of 29 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_set/it/

… in the module sale_product_set. The reason to move this logic is that there are other modules that extend product_set as for example stock_product_set but at the same time make use of the transient model to define a wizard. For this reason it is better to have the logic available in this base module and avoid duplicating code or inheriting from sale_product_set and what this implies in their respective dependencies with the only need to extend the transient model. In addition, the transient model is renamed to make it clearer to identify that it is this type of model. TT48100 [UPD] Update product_set.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-16.0/product-attribute-16.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_set/ Translated using Weblate (Italian) Currently translated at 100.0% (32 of 32 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_set/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-17.0/product-attribute-17.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-17-0/product-attribute-17-0-product_set/

Currently translated at 100.0% (33 of 33 strings) Translation: product-attribute-17.0/product-attribute-17.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-17-0/product-attribute-17-0-product_set/de/

Currently translated at 100.0% (33 of 33 strings) Translation: product-attribute-17.0/product-attribute-17.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-17-0/product-attribute-17-0-product_set/es/

Currently translated at 100.0% (33 of 33 strings) Translation: product-attribute-17.0/product-attribute-17.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-17-0/product-attribute-17-0-product_set/it/

Currently translated at 100.0% (33 of 33 strings) Translation: product-attribute-17.0/product-attribute-17.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-17-0/product-attribute-17-0-product_set/sv/

Currently translated at 93.9% (31 of 33 strings) Translation: product-attribute-17.0/product-attribute-17.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-17-0/product-attribute-17-0-product_set/zh_TW/

Currently translated at 100.0% (33 of 33 strings) Translation: product-attribute-17.0/product-attribute-17.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-17-0/product-attribute-17-0-product_set/it/

Currently translated at 100.0% (36 of 36 strings) Translation: product-attribute-18.0/product-attribute-18.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-18-0/product-attribute-18-0-product_set/it/

In v18 the archive/unarchive action is visible only if the field is not readonly hence we cannot use a related field anymore.

* ease filtering on set and set line views * allow viewing and toggling archived lines on set form

Currently translated at 100.0% (37 of 37 strings) Translation: product-attribute-18.0/product-attribute-18.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-18-0/product-attribute-18-0-product_set/it/

Currently translated at 18.9% (7 of 37 strings) Translation: product-attribute-18.0/product-attribute-18.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-18-0/product-attribute-18-0-product_set/tr/

With the changes introduced in odoo/odoo@de056cc#diff-b37c7fd5520c97a29ddc59495779e7be61a66e15e85603928e27b3affb9dc31f, an error was occurring because the change validation on the model was being performed before tearDownClass was executed. Therefore, it has been modified so that the mock changes are applied in each test and cleaned up after each test. This way, the error will no longer appear and the test will run normally.

BhaveshHeliconia

Code review LGTM!

CRogos · 2026-05-04T08:30:59Z

@pedrobaeza could you have a look and merge?

pedrobaeza · 2026-05-04T08:41:00Z

/ocabot migration product_set

OCA-git-bot · 2026-05-04T08:41:11Z

The migration issue (#2075) has not been updated to reference the current pull request because a previous pull request (#2098) is not closed.
Perhaps you should check that there is no duplicate work.
CC @mmrondon

pedrobaeza · 2026-05-04T08:43:00Z

/ocabot migration product_set

pedrobaeza · 2026-05-04T08:45:23Z

        "res.company", related="product_set_id.company_id", store=True, readonly=True
    )
    name = fields.Char()
-    product_packaging_id = fields.Many2one(


Why removing the package part?

Because there is no product.packaging anymore.

https://github.com/OCA/OpenUpgrade/blob/c7c7393fc92c11fefbe644b6032e3c967dd3f40d/openupgrade_scripts/scripts/product/19.0.1.2/pre-migration.py#L71

(but take your time if you want to have a closer look into this change)

OK, then you would need to add migration scripts to get uom_id filled according OpenUpgrade changes. And what about testing this new field?

Could you have a look at the migration script. I currently have no setup how to test it.

OCA-git-bot · 2026-05-04T17:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza · 2026-05-04T17:36:47Z

-        inverse="_inverse_product_packaging_qty",
-        digits="Product Unit of Measure",
+    uom_id = fields.Many2one(
+        "uom.uom",


Now looking better at the migration script, this should be product.uom not uom.uom.

should we rename the field from uom_id to product_uom_id?

If it's the usual nomenclature for this relation (and it seems it is), yes.

pedrobaeza · 2026-05-04T17:37:31Z

+    cr.execute(
+        """
+        UPDATE product_set_line psl
+        SET uom_id = pt.uom_id


As the product_uom is the same as the product_packaging one, you only need to copy its value.

CRogos · 2026-05-05T13:25:02Z

@MohamedOsman7 @BhaveshHeliconia could you retest? Due to pedros valid feedback, there has been some changes in the implementation.

MohamedOsman7 · 2026-05-07T12:09:44Z

@CRogos I am encountering now the same issue as here: OCA/sale-workflow#4283 (comment)

Christopher Rogos and others added 22 commits April 16, 2026 14:17

[IMP] product_set: pre-commit auto fixes

ac7628b

[MIG] product_set: Migration to 17.0

6744337

Translated using Weblate (German)

a31d8bf

Currently translated at 100.0% (33 of 33 strings) Translation: product-attribute-17.0/product-attribute-17.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-17-0/product-attribute-17-0-product_set/de/

Translated using Weblate (Spanish)

52856c9

Currently translated at 100.0% (33 of 33 strings) Translation: product-attribute-17.0/product-attribute-17.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-17-0/product-attribute-17-0-product_set/es/

Translated using Weblate (Italian)

7435733

Currently translated at 100.0% (33 of 33 strings) Translation: product-attribute-17.0/product-attribute-17.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-17-0/product-attribute-17-0-product_set/it/

[FIX] product_set: pre-commit

4dceb1e

Translated using Weblate (Swedish)

5e7e4c7

Currently translated at 100.0% (33 of 33 strings) Translation: product-attribute-17.0/product-attribute-17.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-17-0/product-attribute-17-0-product_set/sv/

Translated using Weblate (Italian)

3bc93a5

Currently translated at 100.0% (33 of 33 strings) Translation: product-attribute-17.0/product-attribute-17.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-17-0/product-attribute-17-0-product_set/it/

[18.0][MIG] product_set

950f716

[IMP] product_set: add packaging for product.set.line

32fb63a

Translated using Weblate (Italian)

a88cb1e

Currently translated at 100.0% (36 of 36 strings) Translation: product-attribute-18.0/product-attribute-18.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-18-0/product-attribute-18-0-product_set/it/

product_set: fix archive line

47b7998

In v18 the archive/unarchive action is visible only if the field is not readonly hence we cannot use a related field anymore.

product_set: improve archive/unarchive UI

35e70fe

* ease filtering on set and set line views * allow viewing and toggling archived lines on set form

Translated using Weblate (Italian)

c9ddf33

Currently translated at 100.0% (37 of 37 strings) Translation: product-attribute-18.0/product-attribute-18.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-18-0/product-attribute-18-0-product_set/it/

Translated using Weblate (Turkish)

8e2003a

Currently translated at 18.9% (7 of 37 strings) Translation: product-attribute-18.0/product-attribute-18.0-product_set Translate-URL: https://translation.odoo-community.org/projects/product-attribute-18-0/product-attribute-18-0-product_set/tr/

[FIX] product_set: fix product set search behavior

b036149

OCA-git-bot added mod:product_set Module product_set series:19.0 labels Apr 16, 2026

[IMP] product_set: improve view product set

2cf952c

CRogos force-pushed the copilot/migrate-product-set-18-0-to-19-0 branch 5 times, most recently from c9fd859 to 5813d5f Compare April 17, 2026 12:37

BhaveshHeliconia approved these changes Apr 24, 2026

View reviewed changes

CRogos force-pushed the copilot/migrate-product-set-18-0-to-19-0 branch from 5813d5f to 76d5f2b Compare April 30, 2026 20:26

MohamedOsman7 approved these changes May 3, 2026

View reviewed changes

OCA-git-bot added the approved label May 3, 2026

CRogos force-pushed the copilot/migrate-product-set-18-0-to-19-0 branch from 76d5f2b to 648f91a Compare May 4, 2026 08:00

OCA-git-bot added this to the 19.0 milestone May 4, 2026

pedrobaeza mentioned this pull request May 4, 2026

[19.0][MIG] product_set: Migration to 19.0 #2098

Closed

OCA-git-bot mentioned this pull request May 4, 2026

Migration to version 19.0 #2075

Open

73 tasks

pedrobaeza reviewed May 4, 2026

View reviewed changes

CRogos marked this pull request as draft May 4, 2026 14:08

CRogos force-pushed the copilot/migrate-product-set-18-0-to-19-0 branch 2 times, most recently from 9a78e9c to ccfe644 Compare May 4, 2026 16:18

CRogos marked this pull request as ready for review May 4, 2026 16:33

OCA-git-bot added the ready to merge label May 4, 2026

pedrobaeza requested changes May 4, 2026

View reviewed changes

OCA-git-bot removed approved ready to merge labels May 4, 2026

CRogos force-pushed the copilot/migrate-product-set-18-0-to-19-0 branch from ccfe644 to bd8886c Compare May 4, 2026 18:22

CRogos marked this pull request as draft May 4, 2026 18:54

CRogos force-pushed the copilot/migrate-product-set-18-0-to-19-0 branch from bd8886c to 2c3e26d Compare May 5, 2026 11:11

CRogos marked this pull request as ready for review May 5, 2026 12:46

[MIG] product_set: Migration to 19.0

aaa1461

CRogos force-pushed the copilot/migrate-product-set-18-0-to-19-0 branch from 2c3e26d to aaa1461 Compare May 5, 2026 16:49

Uh oh!

Conversation

CRogos commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BhaveshHeliconia left a comment

Choose a reason for hiding this comment

Uh oh!

CRogos commented May 4, 2026

Uh oh!

pedrobaeza commented May 4, 2026

Uh oh!

OCA-git-bot commented May 4, 2026

Uh oh!

pedrobaeza commented May 4, 2026

Uh oh!

pedrobaeza May 4, 2026

Choose a reason for hiding this comment

Uh oh!

CRogos May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pedrobaeza May 4, 2026

Choose a reason for hiding this comment

Uh oh!

CRogos May 4, 2026

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented May 4, 2026

Uh oh!

pedrobaeza May 4, 2026

Choose a reason for hiding this comment

Uh oh!

CRogos May 4, 2026

Choose a reason for hiding this comment

Uh oh!

pedrobaeza May 4, 2026

Choose a reason for hiding this comment

Uh oh!

pedrobaeza May 4, 2026

Choose a reason for hiding this comment

Uh oh!

CRogos commented May 5, 2026

Uh oh!

MohamedOsman7 commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

CRogos commented Apr 16, 2026 •

edited

Loading

CRogos May 4, 2026 •

edited

Loading

MohamedOsman7 commented May 7, 2026 •

edited

Loading