Skip to content

[19.0][ADD] product_class: classes to group product attributes#2273

Open
Ricardoalso wants to merge 1 commit into
OCA:19.0from
camptocamp:product_class
Open

[19.0][ADD] product_class: classes to group product attributes#2273
Ricardoalso wants to merge 1 commit into
OCA:19.0from
camptocamp:product_class

Conversation

@Ricardoalso
Copy link
Copy Markdown

This module introduces Product Classes to group product attributes and standardize product setup.

@Ricardoalso Ricardoalso marked this pull request as draft April 23, 2026 10:06
@Ricardoalso Ricardoalso marked this pull request as ready for review April 23, 2026 11:17
Comment thread product_class/views/product_template_views.xml Outdated
Comment thread product_class/views/product_template_views.xml Outdated
Comment thread product_class/__manifest__.py
Comment thread product_class/tests/test_product_class.py Outdated
Comment thread product_class/models/product_class.py Outdated
Comment thread product_class/models/product_template.py Outdated
Copy link
Copy Markdown
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.

Small comments, pre-approving

Comment thread product_class/models/product_template.py Outdated
Comment thread product_class/views/product_attribute_views.xml Outdated
Comment thread product_class/models/product_attribute.py
Comment thread product_class/models/product_class.py Outdated
@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Copy Markdown
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor remark and a question: have you evaluated using attribute sets from OCA/pim?

Comment thread product_class/tests/test_product_class.py
@ivantodorovich
Copy link
Copy Markdown
Contributor

minor remark and a question: have you evaluated using attribute sets from OCA/pim?

We haven't, but my understanding is that it for a different use case

@Ricardoalso
Copy link
Copy Markdown
Author

minor remark and a question: have you evaluated using attribute sets from OCA/pim?

We haven't, but my understanding is that it for a different use case

After taking a look at the module's description, it seems to be a far more generic module where we could potentially achieve the same things (if we set aside the view overrides done in this product_class), but with a lot more configuration tuning. 🤔

This module is designed to be "plug and play" after installation and has a deterministic scope. But I appreciate you sharing and pointing out this module 🙏

@Ricardoalso
Copy link
Copy Markdown
Author

Ricardoalso commented May 5, 2026

@ivantodorovich as discussed, some new improvements pushed 50ff6fa

Copy link
Copy Markdown
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

Comment thread product_class/models/product_template.py Outdated
Comment thread product_class/models/product_template.py Outdated
Copy link
Copy Markdown
Contributor

@vvrossem vvrossem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the detailed DESCRIPTION.md and USAGE.md 👏

Comment thread product_class/models/product_attribute.py
Comment thread product_class/models/product_attribute.py
Comment thread product_class/models/product_class.py
Comment thread product_class/models/product_class_attribute_line.py
Comment thread product_class/models/product_class_attribute_line.py
Comment thread product_class/models/product_template.py
Comment thread product_class/tests/test_product_class.py
Comment thread product_class/views/product_attribute_views.xml
Comment thread product_class/views/product_class_views.xml
Comment thread product_class/views/product_template_views.xml
Comment thread product_class/views/product_class_views.xml
Comment thread product_class/views/product_class_views.xml
Comment thread product_class/models/product_class.py Outdated
Comment thread product_class/models/product_class.py Outdated
This module introduces Product Classes to group product attributes and standardize product setup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants