[MIG] product_supplierinfo_code: Migration to 19.0#2280
Open
RaphaelVicini wants to merge 17 commits into
Open
Conversation
label is now visible in product.template
Resolved with this if printing odoo/odoo#79897
Translated using Weblate (Italian) Currently translated at 100.0% (4 of 4 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_supplierinfo_code Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_supplierinfo_code/it/
Currently translated at 100.0% (4 of 4 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_supplierinfo_code Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_supplierinfo_code/es/
OCA-git-bot
added
series:19.0
mod:product_supplierinfo_code
RaphaelVicini
force-pushed
the
19.0-mig-product_supplierinfo_code
branch
from
1abf92a to
3e2819a
Compare
BhaveshHeliconia
suggested changes
May 6, 2026
Contributor
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
Consider using BaseCommon instead of TransactionCase. In this case, there’s no need to redefine cls.env with tracking_disable=True, and res.partner is already available via BaseCommon. This would help simplify and optimize the test code.
| from odoo.tests.common import TransactionCase | ||
|
|
||
|
|
||
| class TestSupplierinfoCode(TransactionCase): |
Contributor
There was a problem hiding this comment.
Suggested change
| class TestSupplierinfoCode(TransactionCase): | |
| class TestSupplierinfoCode(Basecommon): |
| @classmethod | ||
| def setUpClass(cls): | ||
| super().setUpClass() | ||
| cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True)) |
Contributor
There was a problem hiding this comment.
Suggested change
| cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True)) |
| super().setUpClass() | ||
| cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True)) | ||
|
|
||
| cls.supplier_1 = cls.env["res.partner"].create({"name": "Supplier 1"}) |
Contributor
There was a problem hiding this comment.
Suggested change
| cls.supplier_1 = cls.env["res.partner"].create({"name": "Supplier 1"}) |
RaphaelVicini
force-pushed
the
19.0-mig-product_supplierinfo_code
branch
from
3e2819a to
dae492e
Compare
Author
|
Thanks for your comment @BhaveshHeliconia |
BhaveshHeliconia
approved these changes
May 7, 2026
Contributor
|
This PR has the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.