Skip to content

[18.0][MIG] project_task_recurring_activity: Migration to 18.0#1768

Open
MarcusPDL wants to merge 11 commits into
OCA:18.0from
Escodoo:pr-1759
Open

[18.0][MIG] project_task_recurring_activity: Migration to 18.0#1768
MarcusPDL wants to merge 11 commits into
OCA:18.0from
Escodoo:pr-1759

Conversation

@MarcusPDL

Copy link
Copy Markdown

SuperSeed #1759

@OCA-git-bot OCA-git-bot added series:18.0 mod:project_task_recurring_activity Module project_task_recurring_activity labels Jul 8, 2026
@CristianoMafraJunior

Copy link
Copy Markdown
Member

cc @luisDIXMIT @alexey-pelykh

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@luisDIXMIT

Copy link
Copy Markdown
Contributor

Could be the fix commit part of the migration process? If so, the commits should be squashed. WDYT?

@MarcusPDL

Copy link
Copy Markdown
Author

Done, I squashed the fix commit into the migration commit. Thanks!

@luisDIXMIT luisDIXMIT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change tests results? Just for my information.

@@ -0,0 +1,6 @@
Open recurring task.

1. In tab "Recurrence", user can set the activites that should be

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab name is "Activities"

<group name="recurring_activity">
<group name="main">
<field name="user_id" />
<field name="project_task_id" invisible="1" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a suggestion, I think putting the Summary field inside the main group would make the layout clearer. The space allocated to that field seems too large to me, and it's very close to the description text, which could be confusing.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants