Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions purchase_blanket_order/models/purchase_order.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,11 @@ def _get_eligible_bo_lines_domain(self, base_qty):
("remaining_qty", ">=", base_qty),
("currency_id", "=", self.order_id.currency_id.id),
("order_id.state", "=", "open"),
(
"company_id",
"in",
[False, self.order_id.company_id.id],
),
]
if self.order_id.partner_id:
filters.append(("partner_id", "=", self.order_id.partner_id.id))
Expand Down
33 changes: 33 additions & 0 deletions purchase_blanket_order/tests/test_purchase_order.py
Original file line number Diff line number Diff line change
Expand Up @@ -215,3 +215,36 @@ def test_02_create_purchase_order(self):
# change partner of the PO line
with self.assertRaises(ValidationError):
po.write({"partner_id": self.partner_2})

def test_get_eligible_bo_lines_domain_company_filter(self):
"""Domain must include company_id to prevent cross-company leakage."""
blanket_order = self.create_blanket_order_01()
blanket_order.sudo().action_confirm()
po = self.purchase_order_obj.create(
{
"partner_id": self.partner.id,
"order_line": [
(
0,
0,
{
"name": self.product.name,
"product_id": self.product.id,
"product_qty": 5.0,
"product_uom": self.product.uom_po_id.id,
"date_planned": date.today(),
"price_unit": 10.0,
},
)
],
}
)
po_line = po.order_line[0]
domain = po_line._get_eligible_bo_lines_domain(5.0)
self.assertIn(
("company_id", "in", [False, po.company_id.id]),
domain,
)
# Ensure other expected filters are still present
self.assertIn(("product_id", "=", self.product.id), domain)
self.assertIn(("order_id.state", "=", "open"), domain)
Loading