Skip to content

[ADD] repair_warehouse#148

Open
sbejaoui wants to merge 1 commit into
OCA:16.0from
acsone:16.0-repair_warehouse-sbj
Open

[ADD] repair_warehouse#148
sbejaoui wants to merge 1 commit into
OCA:16.0from
acsone:16.0-repair_warehouse-sbj

Conversation

@sbejaoui
Copy link
Copy Markdown

This module adds a Warehouse field on Repair Orders to simplify repair location selection in multi-warehouse environments.

When a repair location is chosen, the warehouse is automatically determined and used to filter available locations. This makes location selection clearer and avoids cross-warehouse mistakes.

A consistency rule ensures that the selected warehouse and repair location always belong to the same warehouse.

@sbejaoui sbejaoui force-pushed the 16.0-repair_warehouse-sbj branch 3 times, most recently from b778db3 to e839e56 Compare February 26, 2026 09:19
This module adds a Warehouse field on Repair Orders to simplify
repair location selection in multi-warehouse environments.

When a repair location is chosen, the warehouse is automatically
determined and used to filter available locations. This makes
location selection clearer and avoids cross-warehouse mistakes.

A consistency rule ensures that the selected warehouse and
repair location always belong to the same warehouse.
@sbejaoui sbejaoui force-pushed the 16.0-repair_warehouse-sbj branch from e839e56 to a26b8b7 Compare February 26, 2026 10:04
Copy link
Copy Markdown

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Code + functional)

Copy link
Copy Markdown

@nicolas-delbovier-acsone nicolas-delbovier-acsone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review)

Comment on lines +43 to +54
_(
"Warehouse mismatch:\n"
"- Repair location: %(loc)s (warehouse: %(loc_wh)s)\n"
"- Repair order warehouse: %(order_wh)s\n\n"
"Please select a location belonging to the same warehouse, "
"or change the warehouse to match the location."
)
% {
"loc": rec.location_id.display_name,
"loc_wh": loc_wh.display_name,
"order_wh": rec.warehouse_id.display_name,
}
Copy link
Copy Markdown

@nicolas-delbovier-acsone nicolas-delbovier-acsone Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use the translate function args here to get the fallback mecanism as explained in the doc

_(
    "Warehouse mismatch:\n"
    "- Repair location: %(loc)s (warehouse: %(loc_wh)s)\n"
    "- Repair order warehouse: %(order_wh)s\n\n"
    "Please select a location belonging to the same warehouse, "
    "or change the warehouse to match the location.",
    loc=rec.location_id.display_name,
    loc_wh=loc_wh.display_name,
    order_wh=rec.warehouse_id.display_name,
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants