Skip to content

[18.0][MIG] rma_sale_lot#487

Merged
OCA-git-bot merged 6 commits intoOCA:18.0from
acsone:18.0-rma_sale_lot-sbj
Mar 16, 2026
Merged

[18.0][MIG] rma_sale_lot#487
OCA-git-bot merged 6 commits intoOCA:18.0from
acsone:18.0-rma_sale_lot-sbj

Conversation

@sbejaoui
Copy link
Copy Markdown
Contributor

@sbejaoui sbejaoui commented Oct 27, 2025 •
edited
Loading

@sbejaoui sbejaoui force-pushed the 18.0-rma_sale_lot-sbj branch from 3adf6e9 to 711dba5 Compare October 30, 2025 09:29
@marielejeune
Copy link
Copy Markdown
Contributor

marielejeune commented Nov 5, 2025 •
edited
Loading

Could you remove the test-requirements now that the dependent PR is merged?

And also run pre-commit, and put tests in post-install because of sale_line_warn required field.

@sbejaoui sbejaoui force-pushed the 18.0-rma_sale_lot-sbj branch from 711dba5 to 7f7032a Compare November 10, 2025 15:05
marielejeune
marielejeune approved these changes Nov 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@marielejeune marielejeune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 15, 2026

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 15, 2026
@rousseldenis rousseldenis added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Mar 16, 2026
rousseldenis
rousseldenis approved these changes Mar 16, 2026
View reviewed changes
Copy link
Copy Markdown

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Mar 16, 2026

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Copy Markdown

rousseldenis commented Mar 16, 2026

/ocabot migration rma_sale_lot

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Mar 16, 2026
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 16, 2026
Open
7 tasks
FrancoMaxime
FrancoMaxime approved these changes Mar 16, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@FrancoMaxime FrancoMaxime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: code review

@rousseldenis
Copy link
Copy Markdown

rousseldenis commented Mar 16, 2026

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Mar 16, 2026

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-487-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4003123 into OCA:18.0 Mar 16, 2026
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Mar 16, 2026

Congratulations, your PR was merged at 64b44e5. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

+3 more reviewers

@FrancoMaxime FrancoMaxime FrancoMaxime approved these changes

@acsonefho acsonefho acsonefho approved these changes

@marielejeune marielejeune marielejeune approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 no stale Use this label to prevent the automated stale action from closing this PR/Issue. ready to merge

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

7 participants

@sbejaoui @marielejeune @OCA-git-bot @rousseldenis @FrancoMaxime @acsonefho @mymage