[19.0][MIG] product_warranty: Migration to 19.0#506
Open
fredericgrall wants to merge 67 commits intoOCA:19.0from
Open
[19.0][MIG] product_warranty: Migration to 19.0#506fredericgrall wants to merge 67 commits intoOCA:19.0from
fredericgrall wants to merge 67 commits intoOCA:19.0from
Conversation
…s it seems to be lost in another module that is not here
…ier, in such case, returns the product to the company's address
- Add dependency sale because group "group_sale_salesman" and "group_sale_manager" are defined on modul sales_team * sale depend to sales_team * update ir.model.access base. -> sales_team. - Fix product.prod_config_main not compatible and moved to sale.prod_config_main - Make removed col="6 when add product supplier info field too small (width)
Duplicated msgid
Currently translated at 100.0% (41 of 41 strings) Translation: rma-12.0/rma-12.0-product_warranty Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-product_warranty/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: rma-17.0/rma-17.0-product_warranty Translate-URL: https://translation.odoo-community.org/projects/rma-17-0/rma-17-0-product_warranty/
Currently translated at 100.0% (40 of 40 strings) Translation: rma-18.0/rma-18.0-product_warranty Translate-URL: https://translation.odoo-community.org/projects/rma-18-0/rma-18-0-product_warranty/it/
Currently translated at 100.0% (40 of 40 strings) Translation: rma-18.0/rma-18.0-product_warranty Translate-URL: https://translation.odoo-community.org/projects/rma-18-0/rma-18-0-product_warranty/it/
fredericgrall
changed the title
fredericgrall
force-pushed
the
19.0-mig-product_warranty
branch
2 times, most recently
from
81b5e7b to
7240627
Compare
This was referenced Jan 16, 2026
|
/ocabot migration product_warranty |
rousseldenis
reviewed
Apr 1, 2026
| "return.instruction", | ||
| "Instructions", | ||
| default=_get_default_instructions, | ||
| default=lambda self: self.env["return.instruction"].search( |
There was a problem hiding this comment.
@fredericgrall This change is maybe a little too much. I would have let the function but use the lamda (to avoid static declaration).
|
@fredericgrall could you attend @rousseldenis feedback? Thanks! |
fredericgrall
force-pushed
the
19.0-mig-product_warranty
branch
from
7240627 to
cd5e4a1
Compare
Author
|
@rousseldenis @DavidJForgeFlow , sorry for the delay. I 'm modified |
DavidJForgeFlow
approved these changes
Apr 30, 2026
DavidJForgeFlow
left a comment
DavidJForgeFlow
left a comment
There was a problem hiding this comment.
Minor comment, but the migration is fine!
| ): | ||
| partner_id = record.warranty_return_other_address.id | ||
| record.warranty_return_address = partner_id | ||
|
|
There was a problem hiding this comment.
It's a minor thing here, but you changed the location of the method and it's taken as changes for git. Maybe you could return it to it's previous place.
Contributor
|
This PR has the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.