[18.0][MIG] rma_sale_mrp: Migration to version 18.0 by eduezerouali-tecnativa · Pull Request #525 · OCA/rma

eduezerouali-tecnativa · 2026-01-15T08:04:53Z

Depends on:

[18.0][FIX] rma: create rma when product is consu #547

victoralmau · 2026-02-02T13:08:54Z

            >data.get('phantom_bom_product') and data['quantity'] or 0</attribute>
        </xpath>
-        <!-- TODO: We could give a clue about what's to be returned, with readonly detailed lines -->
+        <!-- TODO: We could give a clue about what's to be returned, with readonly detailed lines


Why is it necessary to comment on this now? If it is not necessary, the corresponding code should be removed and explained.

pedrobaeza · 2026-02-02T15:11:12Z

/ocabot migration rma_sale_mrp

victoralmau

It is not possible to select kit products on the portal.

v16

v18

mariancuadranetkia · 2026-02-20T08:24:33Z

It's not possible create RMA of a Kit, because we receive next error:

I'm not sure if this error could be because the 'delivery order' field isn't automatically filled in the kits, and that's why the validation is being skipped.:

eduezerouali-tecnativa · 2026-03-04T15:23:50Z

@victoralmau sorry for the late replay, now it is working as it should.

eduezerouali-tecnativa · 2026-03-04T15:26:45Z

@mariancuadranetkia first thank you to take the time for the review. Could you give more detail on how you got the error. Anyways i think it has to do with not valid the picking.

mariancuadranetkia · 2026-03-05T06:29:07Z

@eduezerouali-tecnativa
I created a sale with table kit and I finished picking.
After that, I returned to sale order, and I created RMA. Although I could choose product kit to create RMA, when I 'accept' to create it, I got error.
I attach a short video, where you can see the sale order and picking, and error when I try to create RMA. This sale order is created in order to test this feature.

rma.kit.error.mp4

eduezerouali-tecnativa · 2026-03-05T08:46:55Z

@mariancuadranetkia the main problem is that you are using a kit with one product that it is not trackable. Try again creating your own products and components and you will see that RMA is create correctly.

mariancuadranetkia · 2026-03-05T13:13:49Z

@mariancuadranetkia the main problem is that you are using a kit with one product that it is not trackable. Try again creating your own products and components and you will see that RMA is create correctly.

Mmm yes, but, this way customer can't create RMA to ask for a refund if a product is not trackable or a component of kit is not trackable? Because, I can create a return picking without RMA without problem of this product not trackable, problem it's only creating RMA.

I'm not sure if this is the expected behaviour, but, if I can return a product and I can refund it, I don't understand the reason to not allow create RMA to register this operation.

victoralmau · 2026-03-09T14:48:02Z

Reviewing the behavior in v16, it should work correctly, i.e., even if the product kit (table kit, for example) does not have tracking set, if there are stock moves for the kit components, it should allow the corresponding RMA(s) to be created.

eduezerouali-tecnativa · 2026-03-09T14:52:41Z

@victoralmau I have check on v18 to do a RMA from Sale Order and it is not possible to do it if the product is not is_storable

eduezerouali-tecnativa · 2026-03-09T16:30:01Z

@mariancuadranetkia you were right it is fix in this PR #547

mariancuadranetkia · 2026-03-10T07:14:17Z

@eduezerouali-tecnativa ok, I tested this PR and I validated.
But I can't test this fix yet with kits, can I? I've tested in this runbot with same Kit but I have same error, I think that I should wait but I'm not sure.
Thanks!

eduezerouali-tecnativa · 2026-03-10T09:11:36Z

@mariancuadranetkia @victoralmau rebase done, now it should work as expected.

mariancuadranetkia · 2026-03-10T12:18:16Z

@eduezerouali-tecnativa I've checked, and, with new sales order if I create RMA from backend,, it works.
But, if I duplicate sales order, and I try to create RMA from e-commerce, I receive next error:

Thanks!!!

eduezerouali-tecnativa · 2026-03-10T15:02:24Z

@mariancuadranetkia this is a clear bug. It is amend here #548.
Thank you for your review.

pedrobaeza · 2026-03-17T08:58:56Z

Please update this one when the other PR is merged to make use of the new method.

Currently translated at 100.0% (55 of 55 strings) Translation: rma-16.0/rma-16.0-rma_sale_mrp Translate-URL: https://translation.odoo-community.org/projects/rma-16-0/rma-16-0-rma_sale_mrp/pt_BR/

The rma operation is required in the portal, and it makes sense for it to be required in the sales wizard as well

Currently translated at 100.0% (57 of 57 strings) Translation: rma-16.0/rma-16.0-rma_sale_mrp Translate-URL: https://translation.odoo-community.org/projects/rma-16-0/rma-16-0-rma_sale_mrp/it/

Currently translated at 100.0% (57 of 57 strings) Translation: rma-16.0/rma-16.0-rma_sale_mrp Translate-URL: https://translation.odoo-community.org/projects/rma-16-0/rma-16-0-rma_sale_mrp/pt_BR/

- Display the allowed quantity to return - Simplify data encoding by adding a button to select/deselect all lines - Ensure that the quantity to return is always less than or equal to the allowed quantity

Currently translated at 100.0% (62 of 62 strings) Translation: rma-16.0/rma-16.0-rma_sale_mrp Translate-URL: https://translation.odoo-community.org/projects/rma-16-0/rma-16-0-rma_sale_mrp/it/

…s when generating an RMA through the portal Compatibility OCA@822c046#diff-007c4fe2b48020460988c66ea9476f0bc8aa4fd31a24cb2db340aee5544e8169

mariancuadranetkia

Functional review ok!
Now create RMA with Kits or Consu products from backend/e-commerce is working fine.

OCA-git-bot · 2026-03-17T11:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza · 2026-03-17T11:18:29Z

/ocabot merge nobump

OCA-git-bot · 2026-03-17T11:18:37Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-525-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2026-03-17T11:27:00Z

Congratulations, your PR was merged at c9eae9a. Thanks a lot for contributing to OCA. ❤️

eduezerouali-tecnativa force-pushed the 18.0-mig-rma_sale_mrp branch 2 times, most recently from de70770 to f301357 Compare January 15, 2026 09:05

victoralmau suggested changes Feb 2, 2026

View reviewed changes

eduezerouali-tecnativa force-pushed the 18.0-mig-rma_sale_mrp branch 2 times, most recently from 09c10e8 to 899ad94 Compare February 2, 2026 13:39

OCA-git-bot added this to the 18.0 milestone Feb 2, 2026

OCA-git-bot mentioned this pull request Feb 2, 2026

Migration to version 18.0 #425

Open

7 tasks

victoralmau suggested changes Feb 12, 2026

View reviewed changes

eduezerouali-tecnativa force-pushed the 18.0-mig-rma_sale_mrp branch from 899ad94 to c57d0a2 Compare March 4, 2026 15:20

eduezerouali-tecnativa mentioned this pull request Mar 9, 2026

[18.0][FIX] rma: create rma when product is consu #547

Merged

eduezerouali-tecnativa force-pushed the 18.0-mig-rma_sale_mrp branch from c57d0a2 to 16c2c24 Compare March 9, 2026 16:28

eduezerouali-tecnativa force-pushed the 18.0-mig-rma_sale_mrp branch from 16c2c24 to 93f0d9f Compare March 10, 2026 09:08

eduezerouali-tecnativa mentioned this pull request Mar 10, 2026

[18.0][IMP] rma_sale: improve how to get allowed_quantity #548

Closed

eduezerouali-tecnativa mentioned this pull request Mar 16, 2026

[16.0][IMP] rma_sale + rma_sale_mrp: improve how to get allowed_quantity + avoid errors when generating an RMA through the portal #550

Merged

eduezerouali-tecnativa force-pushed the 18.0-mig-rma_sale_mrp branch from 93f0d9f to 440c857 Compare March 17, 2026 09:01

Rodrigo Macedo and others added 8 commits March 17, 2026 10:03

Translated using Weblate (Portuguese (Brazil))

6bb3840

Currently translated at 100.0% (55 of 55 strings) Translation: rma-16.0/rma-16.0-rma_sale_mrp Translate-URL: https://translation.odoo-community.org/projects/rma-16-0/rma-16-0-rma_sale_mrp/pt_BR/

[IMP] rma_sale: operation required

8fedee5

The rma operation is required in the portal, and it makes sense for it to be required in the sales wizard as well

Translated using Weblate (Italian)

766d4ca

Currently translated at 100.0% (57 of 57 strings) Translation: rma-16.0/rma-16.0-rma_sale_mrp Translate-URL: https://translation.odoo-community.org/projects/rma-16-0/rma-16-0-rma_sale_mrp/it/

Translated using Weblate (Portuguese (Brazil))

294a6d4

Currently translated at 100.0% (57 of 57 strings) Translation: rma-16.0/rma-16.0-rma_sale_mrp Translate-URL: https://translation.odoo-community.org/projects/rma-16-0/rma-16-0-rma_sale_mrp/pt_BR/

[IMP] rma: improve rma report layout

e640478

[IMP] rma_sale: Display the allowed quantity to return in the RMA wizard

2f21d7b

- Display the allowed quantity to return - Simplify data encoding by adding a button to select/deselect all lines - Ensure that the quantity to return is always less than or equal to the allowed quantity

[FIX] rma: group rma receptions

fe21291

Translated using Weblate (Italian)

77e109d

Currently translated at 100.0% (62 of 62 strings) Translation: rma-16.0/rma-16.0-rma_sale_mrp Translate-URL: https://translation.odoo-community.org/projects/rma-16-0/rma-16-0-rma_sale_mrp/it/

eduezerouali-tecnativa force-pushed the 18.0-mig-rma_sale_mrp branch from 440c857 to 0c1b09a Compare March 17, 2026 09:03

victoralmau and others added 2 commits March 17, 2026 10:14

[FIX] rma_sale_mrp: Improve how to get allowed_quantity + avoid error…

bc02d32

…s when generating an RMA through the portal Compatibility OCA@822c046#diff-007c4fe2b48020460988c66ea9476f0bc8aa4fd31a24cb2db340aee5544e8169

[IMP] rma_sale_mrp: pre-commit auto fixes

1646a6f

eduezerouali-tecnativa force-pushed the 18.0-mig-rma_sale_mrp branch 3 times, most recently from 00c5c2e to a97040e Compare March 17, 2026 09:49

mariancuadranetkia approved these changes Mar 17, 2026

View reviewed changes

pedrobaeza requested a review from victoralmau March 17, 2026 10:34

[MIG] rma_sale_mrp: Migration to 18.0

c7b5258

eduezerouali-tecnativa force-pushed the 18.0-mig-rma_sale_mrp branch from a97040e to c7b5258 Compare March 17, 2026 10:52

victoralmau approved these changes Mar 17, 2026

View reviewed changes

OCA-git-bot added approved ready to merge labels Mar 17, 2026

OCA-git-bot added the bot is merging ⏳ label Mar 17, 2026

OCA-git-bot merged commit f3c5690 into OCA:18.0 Mar 17, 2026
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 17, 2026

pedrobaeza deleted the 18.0-mig-rma_sale_mrp branch March 17, 2026 11:31

Uh oh!

Conversation

eduezerouali-tecnativa commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

victoralmau Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Feb 2, 2026

Uh oh!

victoralmau left a comment

Choose a reason for hiding this comment

Uh oh!

mariancuadranetkia commented Feb 20, 2026

Uh oh!

eduezerouali-tecnativa commented Mar 4, 2026

Uh oh!

eduezerouali-tecnativa commented Mar 4, 2026

Uh oh!

mariancuadranetkia commented Mar 5, 2026

Uh oh!

eduezerouali-tecnativa commented Mar 5, 2026

Uh oh!

mariancuadranetkia commented Mar 5, 2026

Uh oh!

victoralmau commented Mar 9, 2026

Uh oh!

eduezerouali-tecnativa commented Mar 9, 2026

Uh oh!

eduezerouali-tecnativa commented Mar 9, 2026

Uh oh!

mariancuadranetkia commented Mar 10, 2026

Uh oh!

eduezerouali-tecnativa commented Mar 10, 2026

Uh oh!

mariancuadranetkia commented Mar 10, 2026

Uh oh!

eduezerouali-tecnativa commented Mar 10, 2026

Uh oh!

pedrobaeza commented Mar 17, 2026

Uh oh!

mariancuadranetkia left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Mar 17, 2026

Uh oh!

pedrobaeza commented Mar 17, 2026

Uh oh!

OCA-git-bot commented Mar 17, 2026

Uh oh!

Uh oh!

OCA-git-bot commented Mar 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

eduezerouali-tecnativa commented Jan 15, 2026 •

edited

Loading