[17.0][MIG] fetchmail_attach_from_folder: Migration to 17.0 #3071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zamberjo
force-pushed
the
17.0-mig-fetchmail_attach_from_folder
branch
from
fa91872 to
dbe887f
Compare
zamberjo
force-pushed
the
17.0-mig-fetchmail_attach_from_folder
branch
from
dbe887f to
429b87b
Compare
Contributor
|
Yes, I will review it |
Member
Author
|
Hi @NL66278 have you had a chance to take a look at the PR? |
NL66278
reviewed
Nov 27, 2024
duplicates; don't break existing configurations
- handle situation that optional mail address componenents not present in mail
- slight reorganisation of code to aid debugging and made pep8 compliant as well.
[IMP] more efficient sorting of algorithms [IMP] improve readability of help strings
from imap servers [IMP] clean up the folders' treeview
[IMP] also log when we're done with one folder
mails creates/objects matched [ADD] preliminary docstrings
issues with long running cron threads as rollback also releases the lock
[FIX] use mail_thread.message_parse in wizard
Also possibility to reset state for folder.
Match algorithms other then 'odoo_standard' were not correctly dealt with in the migrated code. For these algorithms we restore the handling (but with improvements) that was present in the 10.0 version.
for the matching record.
zamberjo
force-pushed
the
17.0-mig-fetchmail_attach_from_folder
branch
from
429b87b to
da3ef9f
Compare
NL66278
reviewed
Mar 12, 2025
zamberjo
force-pushed
the
17.0-mig-fetchmail_attach_from_folder
branch
from
da3ef9f to
bdfd30b
Compare
Contributor
|
/ocabot merge nobump |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at 20a6ddf. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping @NL66278, if #3017 is accepted I add it.