Skip to content

[18.0] [MIG] server_action_logging: Migration to 18.0 - #3073

Open
moncefarajdal wants to merge 7 commits into
OCA:18.0from
moncefarajdal:18.0-mig-server_action_logging
Open

[18.0] [MIG] server_action_logging: Migration to 18.0#3073
moncefarajdal wants to merge 7 commits into
OCA:18.0from
moncefarajdal:18.0-mig-server_action_logging

Conversation

@moncefarajdal

Copy link
Copy Markdown

No description provided.

@moncefarajdal moncefarajdal mentioned this pull request Oct 14, 2024
42 tasks
@moncefarajdal moncefarajdal changed the title 18.0 mig server action logging [18.0] [MIG] server_action_logging: Migration to 18.0 Oct 15, 2024

@kanisorn-kate kanisorn-kate left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +9 to +11
<xpath expr="//field[@name='state']" position="after">
<field name="enable_sql_debug" />
</xpath>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor the view for better readability.

Suggested change
<xpath expr="//field[@name='state']" position="after">
<field name="enable_sql_debug" />
</xpath>
<xpath expr="//div[hasclass('flex-column')]" position="after">
<group name="sql_debug">
<field name="enable_sql_debug" />
</group>
</xpath>

@gurneyalex

Copy link
Copy Markdown
Member

/ocabot migration server_action_logging

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone May 21, 2025

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM!

@flotho

flotho commented May 20, 2026

Copy link
Copy Markdown
Member

ping @moncefarajdal , any chance to rebase?
It has already been approved a merge could be fast .
Regads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants