[18.0][FIX] base_name_search_improved: Call the name_search() method with the appropriate limit#3660
Draft
victoralmau wants to merge 1 commit into
Draft
Conversation
…he appropriate limit It is important to call the name_search() method with the appropriate limit so that the filter is truly effective Example use case: - Thousands of products - We apply filter A + smart_search = B - By default, name_search() applies limit=100, so we will only get a total of 100 records to build the domain in _search_smart_search() - When applying the A filter, the smart_search domain will return some incorrect records (4, for example); however, if the total number of possible records were specified as the limit, the correct domain would be returned (20 possible records, for example) TT63353
OCA-git-bot
added
series:18.0
mod:base_name_search_improved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call the
name_search()method with the appropriate limitIt is important to call the name_search() method with the appropriate limit so that the filter is truly effective
Example use case:
@Tecnativa TT63353