[FIX] module_auto_update: skip db-only modules in checksum computation#3674
Open
joshkreud wants to merge 1 commit into
Open
[FIX] module_auto_update: skip db-only modules in checksum computation#3674joshkreud wants to merge 1 commit into
joshkreud wants to merge 1 commit into
Conversation
joshkreud
force-pushed
the
fix/3360-module-auto-update-studio-customization
branch
from
July 15, 2026 11:50
78b7012 to
492bb4e
Compare
joshkreud
marked this pull request as ready for review
July 15, 2026 12:00
joshkreud
marked this pull request as draft
July 15, 2026 12:01
joshkreud
marked this pull request as ready for review
July 15, 2026 12:06
Modules like studio_customization created by web_studio exist only in the database and have no filesystem directory. Previously, module_auto_update would include them in checksum computation, returning False for the checksum. This caused the first upgrade_changed_checksum() run to detect them as "changed" (False != None) and attempt to mark them for upgrade, which fails since the module has no filesystem path. This fix adds _module_exists_on_disk() helper and uses it in both _save_installed_checksums() and _get_modules_with_changed_checksum() to silently skip modules without a filesystem path. Signed-off-by: Joshua Kreuder <Joshua.kreuder@outlook.de>
joshkreud
force-pushed
the
fix/3360-module-auto-update-studio-customization
branch
from
July 15, 2026 12:10
47863fd to
ef817c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modules like
studio_customizationcreated byweb_studioexist only in the database and have no filesystem directory. Previously,module_auto_updatewould include them in checksum computation, returningFalsefor the checksum. This caused the firstupgrade_changed_checksum()run to detect them as "changed" (False != None) and attempt to mark them for upgrade, which fails since the module has no filesystem path.This fix adds a
_module_exists_on_disk()helper and uses it in both_save_installed_checksums()and_get_modules_with_changed_checksum()to silently skip modules without a filesystem path.Note: this fix targets 19.0 only. The same regression affects 16.0, 17.0, and 18.0 — backport PRs are needed for those branches.
Fixes #3360
--
I confirm I have read the DCO (https://github.com/OCA/oca-addons-repo-template/blob/master/CONTRIBUTING.md) and signed it off.