Skip to content

[15.0][ADD] iap_mail_domain_blacklist#1554

Open
AungKoKoLin1997 wants to merge 1 commit into
OCA:15.0from
qrtl:15.0-add-iap_mail_domain_blacklis
Open

[15.0][ADD] iap_mail_domain_blacklist#1554
AungKoKoLin1997 wants to merge 1 commit into
OCA:15.0from
qrtl:15.0-add-iap_mail_domain_blacklis

Conversation

@AungKoKoLin1997
Copy link
Copy Markdown

@AungKoKoLin1997 AungKoKoLin1997 commented Jan 23, 2025

@qrtl QT5135

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-iap_mail_domain_blacklis branch from 30fe07d to c46cb96 Compare February 20, 2025 09:22
@AungKoKoLin1997 AungKoKoLin1997 marked this pull request as ready for review February 20, 2025 09:22
yostashiro
yostashiro reviewed Feb 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AungKoKoLin1997 Can you please add tests and CONTEXT.rst?

Comment thread iap_mail_domain_blacklist/readme/ROADMAP.rst
Copy link
Copy Markdown
Member

@yostashiro yostashiro Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this content should be moved to CONFIGURE.rst.

@AungKoKoLin1997 AungKoKoLin1997 changed the title [ADD] iap_mail_domain_blacklist [15.0][ADD] iap_mail_domain_blacklist Feb 21, 2025
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-iap_mail_domain_blacklis branch from c46cb96 to b4e5e14 Compare February 21, 2025 07:21
yostashiro
yostashiro reviewed Feb 27, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add INSTALL.rst to mention that the module should be server-wide?

Comment thread iap_mail_domain_blacklist/hooks.py Outdated
Comment thread iap_mail_domain_blacklist/hooks.py
Comment thread iap_mail_domain_blacklist/data/config_parameter.xml Outdated
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-iap_mail_domain_blacklis branch from 239ee62 to 893d86a Compare February 27, 2025 08:05
yostashiro
yostashiro reviewed Feb 27, 2025
View reviewed changes
Comment thread iap_mail_domain_blacklist/readme/CONFIGURE.rst Outdated
Comment thread iap_mail_domain_blacklist/__manifest__.py Outdated
Comment thread iap_mail_domain_blacklist/readme/DESCRIPTION.rst Outdated
Comment thread iap_mail_domain_blacklist/readme/DESCRIPTION.rst Outdated
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-iap_mail_domain_blacklis branch 3 times, most recently from 938558b to 38506e6 Compare February 27, 2025 09:02
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-iap_mail_domain_blacklis branch from 38506e6 to 737e3a4 Compare February 27, 2025 09:39
yostashiro
yostashiro approved these changes Feb 27, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.

nobuQuartile
nobuQuartile approved these changes Feb 28, 2025
View reviewed changes
Copy link
Copy Markdown

@nobuQuartile nobuQuartile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

yostashiro
yostashiro reviewed Mar 1, 2025
View reviewed changes
Comment thread iap_mail_domain_blacklist/hooks.py Outdated


def post_load_hook():
for db_name in db.list_dbs():
Copy link
Copy Markdown
Member

@yostashiro yostashiro Mar 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AungKoKoLin1997 Can you check if this is better, please.

Suggested change
for db_name in db.list_dbs():
for db_name in http.db_list():

Copy link
Copy Markdown
Author

@AungKoKoLin1997 AungKoKoLin1997 Mar 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree because sharing blacklist domains across running databases is better than applying them to all databases. http.db_list() ensures that only active databases are considered, making it more efficient in a multi-database environment

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-iap_mail_domain_blacklis branch 2 times, most recently from 8675942 to 5eaf909 Compare March 4, 2025 09:17
kanda999
kanda999 approved these changes Mar 5, 2025
View reviewed changes
Copy link
Copy Markdown

@kanda999 kanda999 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test: It works as expected.

@AungKoKoLin1997
Copy link
Copy Markdown
Author

AungKoKoLin1997 commented Apr 2, 2025 •
edited
Loading

@oca/social-maintainers Is it possible to take a look at this PR?

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 3, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 3, 2025
@kanda999 kanda999 force-pushed the 15.0-add-iap_mail_domain_blacklis branch from 5eaf909 to 6b9ebd7 Compare August 4, 2025 03:37
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Aug 4, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 10, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 14, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 14, 2025
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-iap_mail_domain_blacklis branch from 6b9ebd7 to 4d3a1e4 Compare December 15, 2025 01:27
@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 21, 2025
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-iap_mail_domain_blacklis branch 2 times, most recently from 9d4f7c3 to 0b9d6a4 Compare January 6, 2026 02:06
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 10, 2026

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 10, 2026
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-iap_mail_domain_blacklis branch from 0b9d6a4 to 22710b2 Compare May 11, 2026 04:05
@OCA-git-bot OCA-git-bot added series:15.0 mod:iap_mail_domain_blacklist Module iap_mail_domain_blacklist labels May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nobuQuartile nobuQuartile Awaiting requested review from nobuQuartile

2 more reviewers

@yostashiro yostashiro yostashiro approved these changes

@kanda999 kanda999 kanda999 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved mod:iap_mail_domain_blacklist Module iap_mail_domain_blacklist ready to merge series:15.0 stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AungKoKoLin1997 @OCA-git-bot @yostashiro @kanda999 @nobuQuartile