[15.0][ADD] attachment_mimetype_restriction#1857
Open
AungKoKoLin1997 wants to merge 1 commit into
Open
Conversation
8138261 to
556a7c0
Compare
89a3294 to
232a014
Compare
yostashiro
reviewed
May 8, 2026
Comment on lines
+57
to
+60
| def create(self, vals_list): | ||
| for vals in vals_list: | ||
| self._validate_mimetype_from_vals(vals) | ||
| return super().create(vals_list) |
Member
There was a problem hiding this comment.
What's the handling of JS and CSS files that come from module installation?
232a014 to
061ca2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module blocks specific MIME types from being uploaded as attachments using content-based detection rather than filename extensions. This prevents uploading potentially dangerous files (executables, scripts, etc.).
@qrtl QT5832