Skip to content

[18.0][MIG] web_widget_image_download: Migration to 18.0#3046

Merged
OCA-git-bot merged 25 commits into
OCA:18.0from
HeliconiaIO:18.0-mig-web_widget_image_download
Jul 20, 2026
Merged

[18.0][MIG] web_widget_image_download: Migration to 18.0#3046
OCA-git-bot merged 25 commits into
OCA:18.0from
HeliconiaIO:18.0-mig-web_widget_image_download

Conversation

@BhaveshHeliconia

@BhaveshHeliconia BhaveshHeliconia commented Jan 3, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@BhaveshHeliconia
BhaveshHeliconia force-pushed the 18.0-mig-web_widget_image_download branch from d0a616f to bae4b34 Compare January 3, 2025 12:02
@BhaveshHeliconia BhaveshHeliconia mentioned this pull request Jan 3, 2025
Open
49 tasks
@BhaveshHeliconia
BhaveshHeliconia force-pushed the 18.0-mig-web_widget_image_download branch from bae4b34 to ff1ce80 Compare February 28, 2025 05:30
@BhaveshHeliconia
BhaveshHeliconia force-pushed the 18.0-mig-web_widget_image_download branch from ff1ce80 to 3a5176e Compare March 11, 2026 06:24
@BhaveshHeliconia

BhaveshHeliconia commented Mar 11, 2026

Copy link
Copy Markdown
Contributor Author

Hey @OCA/web-maintainers would be great if someone could have a look at this module.

@BhaveshHeliconia
BhaveshHeliconia force-pushed the 18.0-mig-web_widget_image_download branch from 3a5176e to f99d5f8 Compare July 16, 2026 05:02
@OCA-git-bot OCA-git-bot added series:18.0 mod:web_widget_image_download Module web_widget_image_download labels Jul 16, 2026
@BhaveshHeliconia

BhaveshHeliconia commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

@yajo @alessandro-fiorino @manuelregidor Could you please review this? Thanks!

yajo
yajo approved these changes Jul 17, 2026
View reviewed changes

@yajo yajo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.

etobella
etobella requested changes Jul 18, 2026
View reviewed changes
Comment thread web_widget_image_download/static/src/xml/web_widget_image_download.xml Outdated
class="o_form_binary_file_download btn btn-light border-0 rounded-circle m-1 p-1"
data-tooltip="Download"
aria-label="Download"
t-on-click="onFileDownload"

@etobella etobella Jul 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably misses a .stop to avoid propagation

On runboat, when using the button it downloaded it, but asked at the same time to upload a new image....

@BhaveshHeliconia BhaveshHeliconia Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. I added the missing .stop() to prevent the event from propagating further. I also tested it on Runboat, and the issue is now resolved—the button downloads the image without simultaneously triggering the upload action.

kutyel and others added 19 commits July 20, 2026 09:55
@kutyel @BhaveshHeliconia
[MIG] web_widget_image_download
a1c0306
@yajo @BhaveshHeliconia
[MIG] web_widget_image_download: Update for v9.
d41f27c
@smurf-U @BhaveshHeliconia
[10.0][MIG]migrate web_widget_image_download
73ec161
@ernestotejeda @BhaveshHeliconia
[MIG] web_widget_image_download: Migration to 11.0
12984ad
@pedrobaeza @BhaveshHeliconia
[IMP] README by fragments + manifest
de593dd
@ernestotejeda @BhaveshHeliconia
[MIG] web_widget_image_download: Migration to 12.0
ec81ffa
@liweijie0812 @BhaveshHeliconia
Added translation using Weblate (Chinese (Simplified))
4e74f25
@liweijie0812 @BhaveshHeliconia
Translated using Weblate (Chinese (Simplified))
a701cb7 
Currently translated at 100.0% (1 of 1 strings)

Translation: web-12.0/web-12.0-web_widget_image_download
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_widget_image_download/zh_CN/
@pedrocs-exo @BhaveshHeliconia
Added translation using Weblate (Portuguese)
70c6c2f
@pedrocs-exo @BhaveshHeliconia
Translated using Weblate (Portuguese)
0300f11 
Currently translated at 100.0% (1 of 1 strings)

Translation: web-12.0/web-12.0-web_widget_image_download
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_widget_image_download/pt/
@Tardo @BhaveshHeliconia
[IMP] web_widget_image_download: black, isort
87eca0b
@Tardo @BhaveshHeliconia
[MIG] web_widget_image_download: Migration to 13.0
bfae4e4
@sbidoul @BhaveshHeliconia
pre-commit update: prettier xml indent
88aacfc
@claudiagn @BhaveshHeliconia
Added translation using Weblate (Spanish)
97b35e8
@claudiagn @BhaveshHeliconia
Translated using Weblate (Spanish)
38661c1 
Currently translated at 100.0% (1 of 1 strings)

Translation: web-13.0/web-13.0-web_widget_image_download
Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_widget_image_download/es/
@Peerapong-Supasompob @BhaveshHeliconia
[IMP] web_widget_image_download: black, isort, prettier
9af8f84
@Peerapong-Supasompob @BhaveshHeliconia
[14.0][MIG] web_widget_image_download
e910e8b
@alessandro-fiorino @BhaveshHeliconia
Added translation using Weblate (Italian)
b86998b
@alessandro-fiorino @BhaveshHeliconia
Translated using Weblate (Italian)
fc78659 
Currently translated at 100.0% (1 of 1 strings)

Translation: web-14.0/web-14.0-web_widget_image_download
Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_widget_image_download/it/
@BhaveshHeliconia
BhaveshHeliconia force-pushed the 18.0-mig-web_widget_image_download branch from f99d5f8 to c2205fe Compare July 20, 2026 04:30
etobella
etobella approved these changes Jul 20, 2026
View reviewed changes

@etobella etobella left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and Functional Review

/ocabot migration web_widget_image_download

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jul 20, 2026
@etobella

etobella commented Jul 20, 2026

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-3046-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 2836618 into OCA:18.0 Jul 20, 2026
9 checks passed
@OCA-git-bot

OCA-git-bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 7f257fe. Thanks a lot for contributing to OCA. ❤️

@sergiocorato sergiocorato mentioned this pull request Jul 21, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yajo yajo yajo approved these changes
@etobella etobella etobella approved these changes

Assignees

No one assigned

Labels

approved merged 🎉 mod:web_widget_image_download Module web_widget_image_download series:18.0

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.