[18.0][MIG] web_widget_mermaid: Migration to 18.0#3419
Open
[18.0][MIG] web_widget_mermaid: Migration to 18.0#3419
Conversation
ypapouin
force-pushed
the
18.0-mig-web_widget_mermaid-squash
branch
from
e4b32bd to
4bec74b
Compare
Using the last official version of module web_widget_mermaid as a base for the migration to v15.0
Using new asset definition via manifest and changed from static mermaid.js file to external CDN. Removed web_widget_mermaid_default_theme.scss and web_widget_mermaid_view.xml from mainfest (detailed description in upcoming commits)
This file is no longer needed since assets are now defined in manifest file.
Fixed ESLint messages. Due to issue with mermaid call, the definition has been moved to init and was deactivated for rule 'no-undef'. Inline comments has been moved to additional lines.
Since it seems like null values are no longer working for theme parameter, theme has been set to 'base' and theme config can completely move to web_widget_mermaid.js. web_widget_mermaid_default_theme.scss will be removed in upcoming commit.
SCSS file of default theme can be removed since the theme config moved to web_widget_mermaid.js.
• Add contributor: RoboHeart • Remove 'Upgrading' section from USAGE.rst [ADD] Missing setup files [UPD] Documentation files by oca-gen-addon-readme
ypapouin
force-pushed
the
18.0-mig-web_widget_mermaid-squash
branch
from
4bec74b to
4a347b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration to 18.0 started from 15.0 PR #2763
basewith custom colors, because colors from Odoo's theme can easily break the visuals.options="{'odoo_theme': true}"had been added to keep previous rendering behaviour.Note that I made an attempt to enable the
darkModeby parsing thecolor_schemefrom cookies but the rendering is broken, some visuals are not visible (white on white or black on black) when used withweb_dark_modemodule