Skip to content

[REF] web_company_color: Update fetching scss_template#3426

Open
SirPyTech wants to merge 1 commit intoOCA:18.0from
PyTech-SRL:18.0-ref-web_company_color-override
Open

[REF] web_company_color: Update fetching scss_template#3426
SirPyTech wants to merge 1 commit intoOCA:18.0from
PyTech-SRL:18.0-ref-web_company_color-override

Conversation

@SirPyTech
Copy link

Using a function to fetch SCSS_TEMPLATE to allow easier override from other modules.

Cherry-picked from #3185.

   Using a function to fetch SCSS_TEMPLATE
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review LGTM

@SirPyTech
Copy link
Author

Thanks @flotho and @leemannd for having a look!

@flotho please click on "Approve" if these changes look good to you, so the review counts as an approval in Github Reviewers summary image

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants