Open
Conversation
Otherwise function calls are not evaluated in the created attachment
1705b71 to
177d482
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise function calls are not evaluated in the created attachment.
Right now it is not needed because the created attachment does not use any functions, but if any were added, that would not be evaluated.
For instance, try editing the created CSS by adding a call to the
desaturatefunction like:that would be sent to the client as-is resulting in something like:
that is not acceptable CSS, and thus is not evaluated.
Other SCSS assets are automatically compiled in their bundle, but this one skips that procedure because of the overrides for the
web_company_color.company_color_assetsbundle.