Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion web_field_tooltip/models/res_users.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,15 @@ def TOOLTIP_READABLE_FIELDS(self):

@property
def SELF_READABLE_FIELDS(self):
return super().SELF_READABLE_FIELDS + self.TOOLTIP_READABLE_FIELDS
# ``tooltip_show_add_helper_allowed`` is a computed (read-only) field
# added to the user preferences form, so it must be self-readable too.
# Otherwise the ``res.users.read`` self-read shortcut is skipped and
# reading one's own preferences can raise an AccessError.
return (
super().SELF_READABLE_FIELDS
+ self.TOOLTIP_READABLE_FIELDS
+ ["tooltip_show_add_helper_allowed"]
)

@property
def SELF_WRITEABLE_FIELDS(self):
Expand Down
18 changes: 18 additions & 0 deletions web_field_tooltip/tests/test_web_field_tooltip.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,21 @@ def test_tooltip_model_id(self):
self.Tooltip.with_context(default_model=self.partner_model_name)
)
self.assertEqual(res_partner_form.model_id, self.partner_model)

def test_tooltip_allowed_is_self_readable(self):
# ``tooltip_show_add_helper_allowed`` is displayed on the user
# preferences form, so a user must be able to read it on their own
# record. If it is missing from SELF_READABLE_FIELDS, the res.users
# self-read shortcut is skipped and reading one's own preferences
# (together with any group-restricted field also present on the form)
# raises an AccessError.
user = self.env["res.users"].create(
{
"name": "Test Tooltip User",
"login": "test_tooltip_user",
"groups_id": [(6, 0, [self.env.ref("base.group_user").id])],
}
)
self.assertIn("tooltip_show_add_helper_allowed", user.SELF_READABLE_FIELDS)
# A non-manager user can read the field on their own record.
user.with_user(user).read(["tooltip_show_add_helper_allowed"])
Loading