[16.0][IMP] shopfloor_reception_mobile: display qty_done over total qty in select_move.#1127
Open
nicolas-delbovier-acsone wants to merge 4 commits into
Conversation
Contributor
|
Hi @JuMiSanAr, |
jbaudoux
reviewed
Mar 27, 2026
Comment on lines
+384
to
+386
| renderer: function (rec, field) { | ||
| return rec.quantity_done + " / " + rec.quantity; | ||
| }, |
Contributor
There was a problem hiding this comment.
Ideally, it should display the quantity by packaging
Suggested change
| renderer: function (rec, field) { | |
| return rec.quantity_done + " / " + rec.quantity; | |
| }, | |
| render_component: "packaging-qty-picker-display", | |
| render_props: function (record) { | |
| return self.utils.wms.move_line_qty_picker_props(record, { | |
| qtyInit: record.quantity_done, | |
| # qtyTodo: record.quantity, | |
| }); | |
| }, |
And then the component could be improved to support a qtyTodo to render it the same way
Examples:
- 0 / 1000 (1 PAL, 3 TU)
- 200 (2 TU) / 1000 (1 PAL, 3 TU)
…select_move. This commit changes the rendering of the "Qty done" field on the move card in "select_move" state like so: "Qty done: 7" -> "Qty done: 7/10"
This commit also simplifies the code a bit by moving the string construction from the Vue template to JS method.
8b1dd19 to
40a5afa
Compare
Author
|
@jbaudoux, Here is the new UI with your suggested implementation:
I am not sure if I like that... It is a bit cluttered isn't it? |
Author
|
Also, I needed to make a [FIX] commit because of this change in another scenario:
This is because the code was passing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Uh oh!
There was an error while loading. Please reload this page.