[16.0][FIX] shopfloor_reception/mobile: set_destination validation flow#1159
Merged
OCA-git-bot merged 3 commits intoMay 7, 2026
Merged
Conversation
Replaces the custom location validation logic in shopfloor_reception with the standard 'is_dest_location_valid' method from the base shopfloor module. This avoids code duplication and ensures consistent behavior across the application.
Contributor
|
Hi @JuMiSanAr, @mmequignon, |
jbaudoux
approved these changes
May 7, 2026
Contributor
|
/ocabot merge patch |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 4093b76. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_dest_location_validfrom shopfloor core instead of duplicating the logic inside custom reception function (same idea as in [IMP] shopfloor_reception: Use is_dest_location_valid #1099)