[16.0][FIX] shopfloor_mobile_base: prevent virtual keyboard from disappearing after each keystroke#1160
Draft
nicolas-delbovier-acsone wants to merge 1 commit into
Conversation
…ng after each keystroke
Contributor
|
Hi @simahawk, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the current implementation, manual text entry in the search bar is nearly impossible on mobile devices. After every keystroke, the virtual keyboard hides, requiring the user to tap the input field again for every single character.
Root Cause
Following the changes in #767, a click event is triggered whenever the UI focuses on the search bar. Because the component calls
this.capture_focus()within theupdatedlifecycle hook:updatedhook.capture_focus()is called.I do not have a scanner device to test that the focus still works as expected right now, I'll be testing that soon and come back in here