Skip to content

[16.0][ADD] shopfloor_reception_putinpack_restriction: allow to restrict the use of packages in reception#1163

Merged
OCA-git-bot merged 3 commits into
OCA:16.0from
acsone:16.0-add-shopfloor_reception_putinpack_restriction
May 8, 2026
Merged

[16.0][ADD] shopfloor_reception_putinpack_restriction: allow to restrict the use of packages in reception#1163
OCA-git-bot merged 3 commits into
OCA:16.0from
acsone:16.0-add-shopfloor_reception_putinpack_restriction

Conversation

@nicolas-delbovier-acsone
Copy link
Copy Markdown

@nicolas-delbovier-acsone nicolas-delbovier-acsone commented May 4, 2026

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hi @JuMiSanAr,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot OCA-git-bot added series:16.0 mod:shopfloor_reception_mobile Module shopfloor_reception_mobile mod:shopfloor_reception_putinpack_restriction Module shopfloor_reception_putinpack_restriction labels May 4, 2026
Copy link
Copy Markdown
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the impression you broke set_quantity when a product/product packaging/lot/location is scanned but I don't see any testing failing. Can you check that and add missing tests if indeed it's broken.

Comment thread shopfloor_reception_putinpack_restriction/readme/CONTEXT.md Outdated
Comment thread shopfloor_reception_putinpack_restriction/readme/CREDITS.md Outdated
Comment thread shopfloor_reception_putinpack_restriction/readme/CONTEXT.md Outdated
Comment thread shopfloor_reception_putinpack_restriction/readme/CONTEXT.md Outdated
Comment thread shopfloor_reception_putinpack_restriction/readme/CONTEXT.md Outdated
Comment thread shopfloor_reception_putinpack_restriction/__manifest__.py Outdated
Comment thread shopfloor_reception_putinpack_restriction/services/reception.py
Comment thread shopfloor_reception_putinpack_restriction/readme/CONTRIBUTORS.md Outdated
@nicolas-delbovier-acsone nicolas-delbovier-acsone force-pushed the 16.0-add-shopfloor_reception_putinpack_restriction branch from efbd3ff to 442a886 Compare May 5, 2026 13:26
@OCA-git-bot OCA-git-bot added the mod:shopfloor_reception Module shopfloor_reception label May 5, 2026
@nicolas-delbovier-acsone
Copy link
Copy Markdown
Author

nicolas-delbovier-acsone commented May 5, 2026

It was indeed broken, this should be fixed right now (the unit tests were not failing because it was only broken when the restriction on packages was active -> I added the unit test)

@nicolas-delbovier-acsone nicolas-delbovier-acsone force-pushed the 16.0-add-shopfloor_reception_putinpack_restriction branch from 442a886 to 74ce13b Compare May 5, 2026 14:43
Comment thread shopfloor_reception/services/reception.py Outdated
Comment thread shopfloor_reception_putinpack_restriction/readme/CONFIGURE.md Outdated
Comment thread shopfloor_reception_putinpack_restriction/readme/CONTRIBUTORS.md Outdated
Copy link
Copy Markdown
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you drop changes on auto generated files from existing modules?

@nicolas-delbovier-acsone nicolas-delbovier-acsone force-pushed the 16.0-add-shopfloor_reception_putinpack_restriction branch from 74ce13b to 453bf13 Compare May 6, 2026 08:07
@jbaudoux
Copy link
Copy Markdown
Contributor

jbaudoux commented May 8, 2026

/ocabot merge minor

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1163-by-jbaudoux-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 89a93f3 into OCA:16.0 May 8, 2026
5 of 7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at cb5ebe1. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved merged 🎉 mod:shopfloor_reception_mobile Module shopfloor_reception_mobile mod:shopfloor_reception_putinpack_restriction Module shopfloor_reception_putinpack_restriction mod:shopfloor_reception Module shopfloor_reception series:16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants