[16.0][MIG] shopfloor_gs1#966
Open
rousseldenis wants to merge 13 commits into
Open
Conversation
If you are specifically searching for a type and this type is not supported by our AI mapping, just don't search for it. This is kind of mandatory because otherwise the GS1 parsing will default to all available AIs and can give back unexpected results (eg: search for 'package' and get an empty 'product' back)
rousseldenis
force-pushed
the
16.0-add_gs1-dro
branch
from
39e5ade to
a612edd
Compare
As products barcode in Odoo are stored in GTIN-13 (EAN-13), and as GS1 contains the GTIN-14 representation, don't mix them in tests
simahawk
reviewed
Oct 8, 2025
simahawk
left a comment
simahawk
left a comment
There was a problem hiding this comment.
LGTM
@rousseldenis can you rebase and cleanup? 🙏
Comment on lines
+38
to
+43
| """ | ||
| We must return the date value if set | ||
| We must return the formatted GTIN if set | ||
| as the library will transform the GTIN 14 into | ||
| a GTIN 13 one. That one is the barcode | ||
| set in Odoo. |
There was a problem hiding this comment.
Suggested change
| """ | |
| We must return the date value if set | |
| We must return the formatted GTIN if set | |
| as the library will transform the GTIN 14 into | |
| a GTIN 13 one. That one is the barcode | |
| set in Odoo. | |
| """ | |
| Determine the final value for the given parsed element. | |
| Returns | |
| * date value if set | |
| * formatted GTIN if set | |
| The library will transform the GTIN 14 into | |
| a GTIN 13, which is the one used by Odoo. |
|
One more thing: as the v14 PR was never merged, IMO we can squash the fixup commit ;) |
simahawk
reviewed
Oct 9, 2025
| # >= 2.3.0 required to use 'GS1Message.parse_hri' method | ||
| # and next version 3.0.0 has been refactored bringing | ||
| # incompatibility issues (to check later). | ||
| "biip" |
There was a problem hiding this comment.
the pin of the lib is lost here. It's mandatory as there's no other 2.x version that is suitable
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
github-actions
Bot
removed
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From:
Depends on: