Update to cmdliner 2 - #351
Merged
Merged
Conversation
This also fixes a bug that caused '-' to be rejected as an input argument when ocp-indent was compiled with cmdliner.1.3. Signed-off-by: Nathan Rebours <nathan.rebours@ocamlpro.com>
NathanReb
force-pushed
the
fix-dash-for-stdio
branch
2 times, most recently
from
August 5, 2026 14:46
29e00f0 to
3459c9a
Compare
MisterDA
reviewed
Aug 6, 2026
| "ocaml" {>= "4.11"} | ||
| "dune" {>= "3.20"} | ||
| "cmdliner" {>= "1.3.0"} | ||
| "cmdliner" {>= "2.0.0"} |
There was a problem hiding this comment.
If you're updating to cmdliner.2.0 for bug fixes you might as well set the lower bound to 2.1 for even more bug fixes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #336
This PR updates ocp-indent to cmdliner 2. This was motivated by a bug (that only appeared when ocp-indent was compiled with cmdliner.1.3 and caused
-to be rejected as an input argument instead of being treated asstdin) but it does come with a few extras:we usecmdliner installto install manpages instead of having our custom rulefilepathargument converter instread of the rawstringfor the--outputoption.Edit: I reverted the manpage installation as it was causing errors on windows which I'd rather not spend too much time debugging.