Skip to content

Solaris porting changes.#15092

Open
l1gi wants to merge 1 commit intoOISF:mainfrom
l1gi:main
Open

Solaris porting changes.#15092
l1gi wants to merge 1 commit intoOISF:mainfrom
l1gi:main

Conversation

@l1gi
Copy link
Copy Markdown

@l1gi l1gi commented Mar 24, 2026

Ticket: 7005

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

Our Contribution agreements:

Changes (if applicable):

Link to ticket: https://redmine.openinfosecfoundation.org/issues/7005

Describe changes:

@l1gi l1gi requested a review from victorjulien as a code owner March 24, 2026 13:46
@l1gi l1gi mentioned this pull request Mar 24, 2026
3 tasks
@github-actions
Copy link
Copy Markdown

NOTE: This PR may contain new authors.

@catenacyber
Copy link
Copy Markdown
Contributor

Argh, I guess it will need a rebase to get green CI

@victorjulien
Copy link
Copy Markdown
Member

I'd like to see this split out into different commits, not just a general "Solaris porting changes". Essentially the list of changes in the PR message body has the logical separation I think would be appropriate for the commits. Esp the alignment commit would need to have a bit more explanation of what it does and why.

Copy link
Copy Markdown
Member

@victorjulien victorjulien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code itself looks good, git needs to a cleanup.

Also needs a rebase again.

@l1gi
Copy link
Copy Markdown
Author

l1gi commented Apr 16, 2026

Hi Victor,

so could you help me and list what exact steps should I do to make all this pass? I have done the rebase twice without success. Did I something wrong, please?

Sorry, I am not keen on github development, but I still would like to make these change to get to the repo.

Regards,
m.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants