Skip to content

next/1283/20260326/v1#15112

Merged
victorjulien merged 9 commits intoOISF:mainfrom
victorjulien:next/1283/20260326/v1
Mar 27, 2026
Merged

next/1283/20260326/v1#15112
victorjulien merged 9 commits intoOISF:mainfrom
victorjulien:next/1283/20260326/v1

Conversation

@victorjulien
Copy link
Copy Markdown
Member

catenacyber and others added 9 commits March 26, 2026 19:23
As FTP must have USER before PASS command
unlike IRC which can begin by PASS command

Ticket: 2978
Completes commit 71b59f6

These const are no longer defined in rust suricata crate
As these structs are now in suricata_sys crate
Ticket: 7666

reexport them in suricata crate
cbindgen them to C
As build flag to (some of the) checks that run suricata-verify:
- AlmaLinux 10 (schema, plugins)
- CentOS Stream 9
- Fedora 43 (Suricata Verify codecov)
- Fedora 43 (clang, debug, asan, wshadow, rust-strict, systemd)
- Fedora 43 (gcc, debug, flto, asan, wshadow, rust-strict)
- Fedora (non-root, debug, clang, asan, wshadow, rust-strict, no-ja)
- Ubuntu 22.04 (Debug Validation)
- Debian 12 (xdp)
- Debian 13 (xdp)
- Debian 12 MSRV
- PF_RING

Related to
Ticket OISF#7885
This is needed to generate the `--build-info` report.

Related to
Ticket OISF#7885
@victorjulien victorjulien requested review from a team and jasonish as code owners March 26, 2026 22:15
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.69%. Comparing base (dce2dee) to head (41834f0).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15112      +/-   ##
==========================================
+ Coverage   82.63%   82.69%   +0.06%     
==========================================
  Files         990      990              
  Lines      271599   271706     +107     
==========================================
+ Hits       224429   224690     +261     
+ Misses      47170    47016     -154     
Flag Coverage Δ
fuzzcorpus 61.16% <ø> (+0.10%) ⬆️
livemode 18.36% <ø> (-0.04%) ⬇️
netns 18.38% <ø> (-0.02%) ⬇️
pcap 45.32% <ø> (+0.03%) ⬆️
suricata-verify 66.24% <ø> (+0.06%) ⬆️
unittests 58.85% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suricata-qa
Copy link
Copy Markdown

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.app_layer.flow.ftp 36530 32728 89.59%
.app_layer.error.ftp.gap 3 0 -
.app_layer.error.ftp.parser 362 17 4.7%
.app_layer.tx.ftp 102955 92250 89.6%
.ftp.memuse 121 21 17.36%

Pipeline = 30575

@victorjulien victorjulien added the needs baseline update QA will need a new base line label Mar 27, 2026
@victorjulien victorjulien merged commit 41834f0 into OISF:main Mar 27, 2026
61 checks passed
@victorjulien victorjulien deleted the next/1283/20260326/v1 branch March 27, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs baseline update QA will need a new base line

Development

Successfully merging this pull request may close these issues.

5 participants