Skip to content

Output emptyarrays 5167 v5#7612

Closed
catenacyber wants to merge 5 commits intoOISF:masterfrom
catenacyber:output-emptyarrays-5167-v5
Closed

Output emptyarrays 5167 v5#7612
catenacyber wants to merge 5 commits intoOISF:masterfrom
catenacyber:output-emptyarrays-5167-v5

Conversation

@catenacyber
Copy link
Copy Markdown
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5167

Describe changes:

  • output: do not log empty arrays

There are likely other cases not caught by current suricata-verify tests

suricata-verify-pr: 872
OISF/suricata-verify#872

Updates #7610 with better rust/clippy style

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 6, 2022

Codecov Report

Merging #7612 (4c4461c) into master (a2f857e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7612      +/-   ##
==========================================
- Coverage   75.73%   75.71%   -0.02%     
==========================================
  Files         659      659              
  Lines      185740   185743       +3     
==========================================
- Hits       140669   140637      -32     
- Misses      45071    45106      +35     
Flag Coverage Δ
fuzzcorpus 59.85% <100.00%> (+<0.01%) ⬆️
suricata-verify 52.38% <100.00%> (-0.05%) ⬇️
unittests 60.70% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link
Copy Markdown

Information: QA ran without warnings.

Pipeline 8125

This was referenced Jul 28, 2022
@victorjulien
Copy link
Copy Markdown
Member

Merged in #7653, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants