Conversation
…e-lock.json file, readMe file, stylelintrc.json file
bellom
left a comment
bellom
left a comment
There was a problem hiding this comment.
Hi @OLIPLICHE 👏 ,
Awesome job so far!! 👍
You have done wonderfully well setting up linter and good commit messages 🔥, However, you passed almost all the checklist for this project 👍 just a few issues left to work on............ 🙂
Status: Required Changes! ♻️
Kindly check the comments under the review.
♻️ Kindly re-submit for review after making all those changes 🙂 Thumps -up await you.....
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| <header id="header"> | ||
| <div class="header-container"> | ||
| <div class="logo"> | ||
| <a href="https://github.com/OLIPLICHE/portfolio/pull/1"> My Logo</a> |
There was a problem hiding this comment.
Good job, let's remove line decoration from this anchor tag so that it will fit in with the figma design.
| <main id="main-container"> | ||
| <section class="headline"> | ||
| <div class="headline-main-container"> | ||
| <h1 class="welcome">I am Paka <br> Glad to see you!</h1> |
There was a problem hiding this comment.
Let's make this h1 look like the original one and also use the property line-height in the Figma design
Example:
rloterh
left a comment
rloterh
left a comment
There was a problem hiding this comment.
Status: Approved ✔️
Hi Paka,
Your project is complete! Great job for making the necessary changes recommended by the previous reviewer. There is nothing else to say other than... it's time to merge it 👍.
Congratulations! 🎉🥂
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have 1 more limited review per this project. If you think that the code review was not fair, you can request a second opinion using this form.
| - Html | ||
| - Css | ||
|
|
||
| 👤 **paka** |
There was a problem hiding this comment.
- OPTIONAL
Kindly add a heading### Authorabove your name to ensure a better-structured ReadMe.
| <header id="header"> | ||
| <div class="header-container"> | ||
| <div class="logo"> | ||
| <a href="https://github.com/OLIPLICHE/portfolio/pull/1"> My Logo</a> |
3 participants
PORTFOLIO