Skip to content

Finish R1 public security hardening#88

Open
jmcte wants to merge 3 commits into
mainfrom
codex/issues-79-81-security-hardening
Open

Finish R1 public security hardening#88
jmcte wants to merge 3 commits into
mainfrom
codex/issues-79-81-security-hardening

Conversation

@jmcte
Copy link
Copy Markdown
Contributor

@jmcte jmcte commented May 23, 2026

Summary

  • create new file-backed SQLite databases with owner-only 0600 permissions before SQLite opens them
  • add --all-files-with-untracked, --all-local, and --local scan modes for local untracked artifact checks
  • add MailPlus-focused leak checks for mailbox exports, local metadata/cache stores, and tokenized OAuth/reset/login/payment links
  • document scanner limits as a fast baseline guardrail rather than complete DLP
  • finish R1 public security polish with disclosure SLA language, fixture policy docs, and CONTRIBUTING guidance

Verification

  • bash scripts/check-detect-secrets.sh --all-files
  • bash scripts/check-detect-secrets.sh --all-local
  • PYTHONPATH=src python3.12 -m unittest discover -s tests -p 'test_runtime.py' -v
  • PYTHONPATH=src python3.12 -m unittest discover -s tests -p 'test_secret_scan_script.py' -v
  • bash scripts/ci/run-fast-checks.sh

Closes #79.
Closes #80.
Closes #81.
Closes #82.

Merge Automation

Auto-merge was not enabled after repair because GitHub rejected the command: GraphQL: Auto merge is not allowed for this repository (enablePullRequestAutoMerge).

@jmcte jmcte requested a review from pheidon as a code owner May 23, 2026 15:51
@jmcte jmcte changed the title Harden local metadata guardrails Finish R1 public security hardening May 23, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: de69067745

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/check-detect-secrets.sh
@athena-omt athena-omt added area:ai AI/model/agent behavior surface. review:athena Athena review governance requested. state:waiting-checks Waiting for CI/check status to settle. status:needs-review PR is ready for Athena review. area:security Security, auth, secret, permission, or policy surface. lane:ares Ares validation/test lane. risk:security Security-sensitive change. labels May 23, 2026
@pheidon pheidon added state:needs-repair PR needs repair before review can proceed. and removed state:waiting-checks Waiting for CI/check status to settle. labels May 23, 2026
@athena-omt athena-omt added the state:waiting-checks Waiting for CI/check status to settle. label May 24, 2026
@ares-omt ares-omt removed the state:needs-repair PR needs repair before review can proceed. label May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ai AI/model/agent behavior surface. area:security Security, auth, secret, permission, or policy surface. lane:ares Ares validation/test lane. review:athena Athena review governance requested. risk:security Security-sensitive change. state:waiting-checks Waiting for CI/check status to settle. status:needs-review PR is ready for Athena review.

Projects

None yet

4 participants