Bundle-aware private media serving

[zerolab]

What is the context of this PR?

This enables previewers to view private media when previewing content in a bundle

How to review

• create two preview teams
• create one or more pages (information, statistical article) that with newly uploaded images and docs (1x image, 1x doc, new for each page)
• submit the page(s) for review
• add a new bundle, add the page(s), add one of the teams, and save the bundle for review
• log in with a reviewer from the bundle team - you should be able to view the assets. Make a note of their URLs.
• log in with a reviwer that is not in the bundle team, try to access the asset URLs

Screencast

Follow-up Actions

List any follow-up actions (if applicable), like needed documentation updates or additional testing.

[AdamHawtin]

Testing this locally I can see it working as expected with draft, never published pages in bundle preview. However, when I add an image to an already live page and add that update page to a bundle, it's still not showing to the previewer and raising PermissionDenied. In debug I can see that the referencing_pages queryset is coming back empty for the already live pages.

[zerolab]

Testing this locally I can see it working as expected with draft, never published pages in bundle preview. However, when I add an image to an already live page and add that update page to a bundle, it's still not showing to the previewer and raising PermissionDenied. In debug I can see that the referencing_pages queryset is coming back empty for the already live pages.

@AdamHawtin 567daae

That hit a limitation of the reference index

[sanjeevz3009]

Looks good so far. Will do another round of review later today.

[AdamHawtin]

LGTM 👍

[MebinAbraham]

Mostly all are working as expected, some minor comments and an edge case that needs further consideration.

[BJacksonONS]

@MaciekBaron I'm having issues where the access cookie isn't getting set properly in safari. First thought it was part of the tracking and fingerprinting protection in private browsing but seems to be occurring in regular browsing mode too.

Can't replicate on other browsers though.

[BJacksonONS]

@MaciekBaron I'm having issues where the access cookie isn't getting set properly in safari. First thought it was part of the tracking and fingerprinting protection in private browsing but seems to be occurring in regular browsing mode too.

Can't replicate on other browsers though.

Sorry wasn't super familiar with Safari, turns out it doesn't set 'Secure' cookies on localhost.

[BJacksonONS]

Looks good to me

[MebinAbraham]

🎉

[BJacksonONS]

Re tested with the newest changes.

Rate limiting worked when I set it to a lower value. Wasn't able to hit 20 entries even when intentionally navigating as quickly as I could between pages on a bundle of 21, so think the current default is reasonable.

[sanjeevz3009]

LGTM!