Fix creation of localised URLs for routable pages#546
Merged
MaciekBaron merged 12 commits intomainfrom Apr 17, 2026
Merged
Conversation
AdamHawtin
approved these changes
Apr 1, 2026
Contributor
AdamHawtin
left a comment
There was a problem hiding this comment.
LGTM, working as expected with both path and subdomain based routing locally 👍
sanjeevz3009
approved these changes
Apr 14, 2026
Contributor
sanjeevz3009
left a comment
There was a problem hiding this comment.
Did a code review, looks good. Did a functional review locally, and this addresses the change needed from CMS-1103 and CMS-765.
Contributor
Author
|
@MebinAbraham CMS-1165 has been addressed here: 59150db |
BJacksonONS
approved these changes
Apr 16, 2026
Contributor
BJacksonONS
left a comment
There was a problem hiding this comment.
Looks good to me, tested 404 pages also with subdomain and path routing.
BJacksonONS
approved these changes
Apr 16, 2026
MebinAbraham
approved these changes
Apr 17, 2026
MebinAbraham
approved these changes
Apr 17, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
This PR relates to a bug described in CMS-1103 which caused the language switcher to not preserve the correct path across domains for all page types.
This PR implements the proposed solution, which preserves the current request path by default and only swaps the language domain or prefix.
This also resolves CMS-765 and CMS-1165.
Specifically, the commit 59150db addresses CMS-1165.
How to review
ArticleSeriesPagewith/editions)This should be tested for both subdomain and path based locales.
Deployment Safety
Bleed and Sandbox deploy automatically on merge, so PRs should be safe to deploy immediately.
Please select one:
Follow-up Actions