Fix Privacy Settings Password Required Template & Wire In Florence SSO To Privacy Settings#575
Draft
sanjeevz3009 wants to merge 4 commits intomainfrom
Draft
Fix Privacy Settings Password Required Template & Wire In Florence SSO To Privacy Settings#575sanjeevz3009 wants to merge 4 commits intomainfrom
sanjeevz3009 wants to merge 4 commits intomainfrom
Conversation
… settings that require logging in.
…GIN_ENABLED default reverted back to false.
…lowed hosts and schemes. - CoPilot keeps flagging weird stuff
…ed for post-login redirects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
This PR is a initative taken after reviewing #568 where I uncovered the below issues, which this PR aims to address.
This PR addresses several issues:
404. -> when it's meant to show thepassword_required.htmltemplate. We have missed this during theNonTrailingSlashRedirectMiddlewarework.password_required.htmltemplate and how it surfaces the error to the user etc.Private, accessible to any logged-in usersorPrivate, accessible to users in specific groupsoptions, then we render thelogin_page.htmltemplate, and the logic behind it would not work due toWAGTAIL_CORE_ADMIN_LOGIN_ENABLED=False/ Wagtail core login being turned off in the deployed environments. + This template UI design/ UX needs improving.How to review
Private, accessible to any logged-in usersorPrivate, accessible to users in specific groupspage privacy options. To do this, you will need to use thedis-authentication-stublocally to try to simulate the SSO user journey/ flow. See the PR description on how: feat(auth): add AWS Cognito JWT authentication support #163password_required.htmltemplate form features and make sure the errors are surfaced properly now to the user.Deployment Safety
Bleed and Sandbox deploy automatically on merge, so PRs should be safe to deploy immediately.
Please select one:
Follow-up Actions
List any follow-up actions (if applicable), like needed documentation updates or additional testing.