You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I do not see any unit test for global variables, for example with en EFX rule like:
LET text* : $global-org-ids = OPT-200-Organization-Company:rawValue;
WITH OPT-300-Contract-Signatory
ASSERT OPT-300-Contract-Signatory in $global-org-ids
AS ERROR R-4ZU-5UE
FOR OPT-300-Contract-Signatory
IN *
From this rule, OPT-300-Contract-Signatory effectively depends on OPT-200-Organization-Company.
But I'm not sure if it is supposed to be handled by the dependency extraction.
I do not see any unit test for global variables, for example with en EFX rule like:
LET text* : $global-org-ids = OPT-200-Organization-Company:rawValue;
WITH OPT-300-Contract-Signatory
ASSERT OPT-300-Contract-Signatory in $global-org-ids
AS ERROR R-4ZU-5UE
FOR OPT-300-Contract-Signatory
IN *
From this rule, OPT-300-Contract-Signatory effectively depends on OPT-200-Organization-Company. But I'm not sure if it is supposed to be handled by the dependency extraction.
Indeed, indirect dependencies through variable references are not currently being detected.
In general, this feature is meant for client-side validation so it should actually exclude the post-validation rules.
This type of implementation is currently encountered in in rules meant to be for post-validation (on the xml).
Nevertheless, I should consider this in a future iteration and I will create a ticket for it.
For this iteration i think this should be left out of scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.