Skip to content

TEDEFO 5001 dependency graph#163

Merged
bertrand-lorentz merged 3 commits intodevelopfrom
TEDEFO-5001-dependency-graph
Mar 25, 2026
Merged

TEDEFO 5001 dependency graph#163
bertrand-lorentz merged 3 commits intodevelopfrom
TEDEFO-5001-dependency-graph

Conversation

@rousso
Copy link
Copy Markdown
Contributor

@rousso rousso commented Mar 25, 2026

No description provided.

@rousso rousso requested a review from bertrand-lorentz March 25, 2026 01:43
@bertrand-lorentz
Copy link
Copy Markdown
Contributor

I do not see any unit test for global variables, for example with en EFX rule like:

LET text* : $global-org-ids = OPT-200-Organization-Company:rawValue;

WITH OPT-300-Contract-Signatory
  ASSERT OPT-300-Contract-Signatory in $global-org-ids
    AS ERROR R-4ZU-5UE
    FOR OPT-300-Contract-Signatory
    IN *

From this rule, OPT-300-Contract-Signatory effectively depends on OPT-200-Organization-Company.
But I'm not sure if it is supposed to be handled by the dependency extraction.

@rousso
Copy link
Copy Markdown
Contributor Author

rousso commented Mar 25, 2026

I do not see any unit test for global variables, for example with en EFX rule like:

LET text* : $global-org-ids = OPT-200-Organization-Company:rawValue;

WITH OPT-300-Contract-Signatory
  ASSERT OPT-300-Contract-Signatory in $global-org-ids
    AS ERROR R-4ZU-5UE
    FOR OPT-300-Contract-Signatory
    IN *

From this rule, OPT-300-Contract-Signatory effectively depends on OPT-200-Organization-Company. But I'm not sure if it is supposed to be handled by the dependency extraction.

Indeed, indirect dependencies through variable references are not currently being detected.
In general, this feature is meant for client-side validation so it should actually exclude the post-validation rules.
This type of implementation is currently encountered in in rules meant to be for post-validation (on the xml).
Nevertheless, I should consider this in a future iteration and I will create a ticket for it.
For this iteration i think this should be left out of scope.

@bertrand-lorentz
Copy link
Copy Markdown
Contributor

OK to have indirect dependencies through variable references out of scope for now.
Just want to ensure it was not an oversight.

@bertrand-lorentz bertrand-lorentz merged commit 9133127 into develop Mar 25, 2026
1 of 2 checks passed
@bertrand-lorentz bertrand-lorentz deleted the TEDEFO-5001-dependency-graph branch March 25, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants