Skip to content

HYRAX-1973: bes build questions#1284

Draft
hannahilea wants to merge 6 commits intomasterfrom
jhrg/HYRAX-1973-bes-build-questions
Draft

HYRAX-1973: bes build questions#1284
hannahilea wants to merge 6 commits intomasterfrom
jhrg/HYRAX-1973-bes-build-questions

Conversation

@hannahilea
Copy link
Copy Markdown
Contributor

@hannahilea hannahilea commented Mar 30, 2026

Description

Reference ticket: HYRAX-1973

I have some questions about the Dockerfile code

Tasks

  • Ticket exists and is linked in title
  • Tests added/updated
  • Dead code removed
  • No TODOs added

@hannahilea hannahilea changed the title Jhrg/hyrax 1973 bes build questions HYRAX-1973: bes build questions Mar 30, 2026
Comment on lines +71 to +73
# *** Note that since this is going to be used in production, the --enable-developer
# configure option should not be used. This is the only change that I think we need
# to make to the build process for production images. jhrg 3/29/26
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of the current master branch, it looks like the additional build time for the docker images is on the order of 3-5 minutes longer than check, and are roughly on par with distcheck.

Note that---as compared to the previous RPM builds---our docker builds DO include running all unit tests.

Elsewhere (slack!) you noted that this was primarily for build speed reasons; if that is the primary reason, let's file it as an improvement but not block a production deployment on it?

Image

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --enable-developer option does not influence build speed much, if at all. The --enable-developer option to configure changes how the code is compiled. It makes the code run more slowly (by adding in a number of debugging helpers like all those BESDEBUG() lines plus a bunch more things and disabling compiler optimizations).

Comment on lines +206 to +207
# We have some contributed scripts that work with systemctl, is it worth trying to set up
# systemctl in this image? jhrg 3/29/26
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be!

jgallagher59701 and others added 2 commits March 30, 2026 15:26
Co-authored-by: Hannah Robertson <hannahilea@users.noreply.github.com>
jgallagher59701 and others added 2 commits March 31, 2026 10:22
Co-authored-by: Hannah Robertson <hannahilea@users.noreply.github.com>
Co-authored-by: Hannah Robertson <hannahilea@users.noreply.github.com>
@sonarqubecloud
Copy link
Copy Markdown

@sonarqubecloud
Copy link
Copy Markdown

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants