Merged
Conversation
|
|
|
kyang2014
approved these changes
Mar 31, 2026
Collaborator
kyang2014
left a comment
kyang2014
left a comment
There was a problem hiding this comment.
Approved with one question: can you duplicate this in your local system?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reference ticket: HYRAX-2076
The GCTP code in the hdf5_handler has at least one function - gctp() - that is using a very old definition form. Modern compilers reject this and it's now tripping up our CICD system on OSX. To see if this works as a fix, run the PR as ready for review even though that's not 100% true (the OSX builds don't run on draft PRs).
Tasks