Switch el9-builds to build from bes_core docker image instead of RPMs#120
Merged
hannahilea merged 18 commits intohr/HYRAX-1964-use-dockerized-besfrom Mar 6, 2026
Merged
Conversation
Merged
5 tasks
Contributor
Author
|
These Travis builds will fail until OPENDAP/bes#1238 is merged. EDIT: merged 3/5 |
hannahilea
commented
Mar 4, 2026
| - master | ||
| - main | ||
| - /^(.*-test-deploy)$/ | ||
| - hr/HYRAX-1964-use-dockerized-bes |
Contributor
Author
There was a problem hiding this comment.
- TODO before merge: remove this addition (+ 2 more lower down)
Contributor
Author
There was a problem hiding this comment.
...am going to wait and remove them in #107, so we can continue to see them pass for this branch!
Build Version Matrix: TARGET_OS: el8 libdap4-3.21.1-390 2026-03-04T03:14:01+0000 bes-3.21.1-1096 2026-03-04T23:14:34+0000 olfs-1.18.15-726 2026-03-04T23:29:26+0000 hyrax-1.17.1-726 2026-03-04T23:29:26+0000
Build Version Matrix: TARGET_OS: el9 TOMCAT_MAJOR_VERSION: 11 libdap4-3.21.1-390 2026-03-04T03:14:01+0000 bes-3.21.1-1096 2026-03-04T23:14:34+0000 olfs-1.18.15-727 2026-03-05T00:05:12+0000 hyrax-1.17.1-727 2026-03-05T00:05:12+0000
Build Version Matrix: TARGET_OS: el8 libdap4-3.21.1-390 2026-03-04T03:14:01+0000 bes-3.21.1-1096 2026-03-04T23:14:34+0000 olfs-1.18.15-730 2026-03-05T17:35:18+0000 hyrax-1.17.1-730 2026-03-05T17:35:18+0000
Build Version Matrix: TARGET_OS: el8 libdap4-3.21.1-390 2026-03-04T03:14:01+0000 bes-3.21.1-1101 2026-03-05T17:25:18+0000 olfs-1.18.15-731 2026-03-05T17:37:19+0000 hyrax-1.17.1-731 2026-03-05T17:37:19+0000
Build Version Matrix: TARGET_OS: el9 TOMCAT_MAJOR_VERSION: 11 libdap4-3.21.1-390 2026-03-04T03:14:01+0000 bes-3.21.1-1101 2026-03-05T17:25:18+0000 olfs-1.18.15-732 2026-03-05T18:13:42+0000 hyrax-1.17.1-732 2026-03-05T18:13:42+0000
bes_core docker image instead of RPMs
ndp-opendap
approved these changes
Mar 5, 2026
Collaborator
ndp-opendap
left a comment
There was a problem hiding this comment.
Wee change suggestions, looks like it's Great!
| bes_uid="$(id -u bes)" | ||
| bes_username="$BES_USER" | ||
| bes_uid="$(id -u ${bes_username})" | ||
| echo "bes_uid: $bes_uid" |
Collaborator
There was a problem hiding this comment.
Note:
No change needed just an observation:
The output of these echo statements are used by other software to determine the bes user's uid:gid so that the permissions on mounted volumes can be altered to match what the docker image expects.
So it's good that these bits remain unchanged...
hannahilea
added a commit
that referenced
this pull request
Mar 10, 2026
…ead of bes and libdap rpms (#107) * fixes made on other branch * use bes_core docker image as hyrax docker base image * comment out travis stages not yet updated * fix travis for main build * Update besd image to use bes_core * enable besd in travis build * enable hyrax_ncwms building * build ngap image from bes_core base image * undo unneeded hyrax docker change * add missing var * clean up use of bes_core_image_tag * do not fail regression test when no log provided * move bes_core_image_tag definition to build-el8 * force to el8 * remove whitespace poke travis * remove besd rpm fetchin gfrom el8 * export core_image_tag * comment out to fail slower * Apply suggestion from @hannahilea * Apply suggestion from @hannahilea * Trigger cicd * Trigger cicd * Refining image name test * Refining image name test * remove cruft * change approach to hardcoding build recipe * java11 to java17 in prep for bump on master * revert build recipe override * use different approach to forcing el8 build * add back vestigial .pem file substitutions * rename USER to BES_USER * revert path to ngap_netrc file * Switch el9-builds to build from `bes_core` docker image instead of RPMs (#120) * Update el-9 shared and besd build * update el9 hyrax * udpate el9 ngap * clean up * update helper functions * update .travis.yml to run CI on branch * i suppose equals signs are important * OLFS: Triggering hyrax-docker image production for el8. Build Version Matrix: TARGET_OS: el8 libdap4-3.21.1-390 2026-03-04T03:14:01+0000 bes-3.21.1-1096 2026-03-04T23:14:34+0000 olfs-1.18.15-726 2026-03-04T23:29:26+0000 hyrax-1.17.1-726 2026-03-04T23:29:26+0000 * OLFS: Triggering hyrax-docker image production for el9. Build Version Matrix: TARGET_OS: el9 TOMCAT_MAJOR_VERSION: 11 libdap4-3.21.1-390 2026-03-04T03:14:01+0000 bes-3.21.1-1096 2026-03-04T23:14:34+0000 olfs-1.18.15-727 2026-03-05T00:05:12+0000 hyrax-1.17.1-727 2026-03-05T00:05:12+0000 * OLFS: Triggering hyrax-docker image production for el8. Build Version Matrix: TARGET_OS: el8 libdap4-3.21.1-390 2026-03-04T03:14:01+0000 bes-3.21.1-1096 2026-03-04T23:14:34+0000 olfs-1.18.15-730 2026-03-05T17:35:18+0000 hyrax-1.17.1-730 2026-03-05T17:35:18+0000 * OLFS: Triggering hyrax-docker image production for el8. Build Version Matrix: TARGET_OS: el8 libdap4-3.21.1-390 2026-03-04T03:14:01+0000 bes-3.21.1-1101 2026-03-05T17:25:18+0000 olfs-1.18.15-731 2026-03-05T17:37:19+0000 hyrax-1.17.1-731 2026-03-05T17:37:19+0000 * OLFS: Triggering hyrax-docker image production for el9. Build Version Matrix: TARGET_OS: el9 TOMCAT_MAJOR_VERSION: 11 libdap4-3.21.1-390 2026-03-04T03:14:01+0000 bes-3.21.1-1101 2026-03-05T17:25:18+0000 olfs-1.18.15-732 2026-03-05T18:13:42+0000 hyrax-1.17.1-732 2026-03-05T18:13:42+0000 * install chkconfig for el9 * fix spelling bork * rearrange * update chkconfig install * tweaks from code review --------- Co-authored-by: Hannah Robertson <1076701+hannahilea@users.noreply.github.com> Co-authored-by: The-Robot-Travis <npotter@opendap.org> * remove travis testing cruft * force el8 build * for testing always push images * revert travis change * remove more rpm cruft * fix path in entrypoints --------- Co-authored-by: Hannah Robertson <1076701+hannahilea@users.noreply.github.com> Co-authored-by: ndp-opendap <ndp@opendap.org> Co-authored-by: The-Robot-Travis <npotter@opendap.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on changes made in #107; I applied the same changes to the el9-builds as were made for the el8-builds in #107.
This branch will then get merged into PR #107, so that when #107 merges down both el8 and el9 will be good.