Open
Conversation
streeve
reviewed
Sep 25, 2025
Collaborator
streeve
left a comment
streeve
left a comment
There was a problem hiding this comment.
Could probably simplify some more of the code, but it looks reasonable on first look
Comment on lines
+354
to
+359
| for ( int step = 1; step <= solver.num_steps; ++step ) | ||
| { | ||
| solver.runStep( step, body ); | ||
|
|
||
| // Removed feeding of particles | ||
| } |
Collaborator
There was a problem hiding this comment.
Suggested change
| for ( int step = 1; step <= solver.num_steps; ++step ) | |
| { | |
| solver.runStep( step, body ); | |
| // Removed feeding of particles | |
| } | |
| solver.run( body ); |
Comment on lines
+261
to
+263
| vel( pid, 0 ) = 0.0; | ||
| vel( pid, 1 ) = 0.0; | ||
| vel( pid, 2 ) = 0.0; |
Collaborator
There was a problem hiding this comment.
Suggested change
| vel( pid, 0 ) = 0.0; | |
| vel( pid, 1 ) = 0.0; | |
| vel( pid, 2 ) = 0.0; |
Always initialized to zero
| int seed = 3837485; | ||
| addConeParticles( solver, inputs, seed ); | ||
| //-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | ||
| updateParticles( solver, inputs ); |
Collaborator
There was a problem hiding this comment.
We only need to do this once, so it could be prior to creating the solver (as in most of the examples)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial example of raking a pile of particles. The file was created by modifying the AoR example file #220
Missing inputs and CMake