Skip to content

ConstantSignalSource component and example with BusToSignalAdapter#457

Merged
pelesh merged 2 commits into
developfrom
PhilipFackler/constant-signal-source
Jun 26, 2026
Merged

ConstantSignalSource component and example with BusToSignalAdapter#457
pelesh merged 2 commits into
developfrom
PhilipFackler/constant-signal-source

Conversation

@PhilipFackler

@PhilipFackler PhilipFackler commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Description

Introduce new component model as a simple example of sending currents to buses via the bus signal adapter

Proposed changes

ConstantSignalSource takes complex parameter and makes it available on output signal nodes (real and imag).

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • [p] There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

@PhilipFackler PhilipFackler requested a review from pelesh June 19, 2026 20:43
@PhilipFackler PhilipFackler force-pushed the PhilipFackler/constant-signal-source branch from d015d61 to c9c2793 Compare June 19, 2026 20:46
@pelesh pelesh requested a review from lukelowry June 24, 2026 16:36
@pelesh

pelesh commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

I suggest we document this better and mark it ready for review. @lukelowry might have additional suggestions how to make the usage example more relevant for domain experts.

@PhilipFackler PhilipFackler force-pushed the PhilipFackler/constant-signal-source branch 2 times, most recently from ec1939f to a8f4d5b Compare June 25, 2026 18:26
@PhilipFackler PhilipFackler marked this pull request as ready for review June 25, 2026 18:28
@PhilipFackler PhilipFackler force-pushed the PhilipFackler/constant-signal-source branch from a8f4d5b to e32bfaf Compare June 25, 2026 18:40

@pelesh pelesh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are issues with how signals are handled in GridKit that are inherited in this PR but are out of scope here (see #407).

For now please rebase and we can merge this PR.

@PhilipFackler PhilipFackler force-pushed the PhilipFackler/constant-signal-source branch from e32bfaf to c19fcdc Compare June 26, 2026 21:05
@PhilipFackler PhilipFackler force-pushed the PhilipFackler/constant-signal-source branch from 5fa2062 to 93b664e Compare June 26, 2026 21:07
@pelesh pelesh merged commit 0a12711 into develop Jun 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants