Conversation
media/js/tables.js
Outdated
There was a problem hiding this comment.
Remove editable table mode*
|
batch update form shows when there aren't any interfaces in the zone (like, a zone without dynamic interfaces, or static). It shows the create an interface form, as well as the batch update form below it. should restrict ranges based on user permissions as well. |
|
Missing a form.make_usable(request) call in base/views |
_usable to batchupdateform
|
This has been good to for a while, someone should test it though. |
|
I will be getting this up to date after #710 is completed. |
…Update Conflicts: cyder/cydhcp/interface/urls.py cyder/cydhcp/interface/views.py cyder/templates/cydhcp/cydhcp_view.html media/js/tables.js
|
This seems to be working still. I just need to clean it all up a bit. |
|
Intriguing. A couple comments:
|
|
If I try to move an interface that can't be moved (like a glue record), the ValidationError propagates all the way up to the view, causing a server error. |
|
In the dynamic interface list page, there are non-breaking spaces before and after each IP range in the range column (I don't know why). When I enter batch update mode, they show up as " ". |
There was a problem hiding this comment.
You might consider rolling back the transaction here instead of manually deleting things. If not, you need to at least handle ValidationErrors, although I'm not sure how that would work.
|
When changing a dynamic interface to a static one, the name is constructed incorrectly. |
|
Under certain circumstances, the view attempts to create a static interface whose container doesn't match its domain. It happened when I created a dynamic interface in |
|
This is going to be a little more tricky than I planned. |
|
Is this still in please review status? |
As mentioned in #426