Open
Conversation
dhirensr
reviewed
Aug 27, 2022
core/load.py
Outdated
| network_traffic_capture_process.terminate() | ||
| # without ci it will be terminate after a few seconds, it needs to kill the tshark and update pcap file collection | ||
| network_traffic_capture_process.join() | ||
| # network_traffic_capture_process.join() |
spiderxm
force-pushed
the
tests-for-containers
branch
from
3c1f170 to
dcff265
Compare
Collaborator
Author
dhirensr
reviewed
Sep 14, 2022
| break | ||
| sys.stdout.buffer.write(c) | ||
| output += c.decode("utf-8") | ||
| if messages["network_traffic_capture_start"] in output and is_network_traffic_capture_started is False: |
Collaborator
There was a problem hiding this comment.
for variables lets use = operator
Collaborator
Author
There was a problem hiding this comment.
for output we cant use == as output is being appended after getting data from the output stream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added test cases to test graceful shutting of modules.
docker kill module_container_name)Ctrl + Cevent to the command line)Screenshots (if appropriate):