Release/trigger v5 tag#38
Merged
Merged
Conversation
JeffreyShran
approved these changes
Jun 17, 2026
There was a problem hiding this comment.
Pull request overview
Updates the release workflow to prevent legacy TASVS tags from affecting TCASVS versioning, and ensures workflow changes can actually trigger the release pipeline.
Changes:
- Add
.github/workflows/main.ymltopush/pull_requestpath filters so workflow edits trigger CI/release. - Guard version derivation so only
v5.x.ytags are incremented; otherwise default tov5.0.0. - Update sponsor text in
index.md(“Bentley” → “Bentley Systems”).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
index.md |
Updates sponsor description text. |
.github/workflows/main.yml |
Adjusts workflow triggers and adds a v5-only version increment guard for releases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root cause
The release workflow in main.yml derives the next version by reading the latest GitHub release tag and bumping the patch number. Because the repo still had a legacy v1.8.0 TASVS tag, the merge of PR #36 produced v1.8.1 instead of 5.0.0.
Fix 1 — version guard main.yml
The workflow now only increments when the latest tag matches v5.x. Any other case (legacy v1.8.x or no tag) produces v5.0.0. So legacy TASVS tags can no longer drive TCASVS versioning.
Fix 2 — trigger path main.yml
The workflow only ran on changes under 5.0/, docker/, or Makefile. I added .github/workflows/main.yml to the trigger paths so merging this fix actually runs the release job.