Nco/enh/calculation option#7
Conversation
ncouvert
force-pushed
the
nco/enh/calculationOption
branch
3 times, most recently
from
0845790 to
79bd6eb
Compare
ncouvert
force-pushed
the
nco/enh/dependencyLink
branch
from
99b11f2 to
7ca97b2
Compare
ncouvert
force-pushed
the
nco/enh/calculationOption
branch
from
79bd6eb to
af5466e
Compare
ncouvert
force-pushed
the
nco/enh/dependencyLink
branch
3 times, most recently
from
a7e2072 to
ef752ad
Compare
ncouvert
force-pushed
the
nco/enh/calculationOption
branch
from
af5466e to
a684255
Compare
lfasani
force-pushed
the
nco/enh/calculationOption
branch
from
a684255 to
0748558
Compare
| if (lastTask.getEndTime().equals(lastTask.getStartTime())) { | ||
| // If the last task is a Milestone | ||
| task.setStartTime(lastTask.getEndTime()); | ||
| task.setEndTime(Instant.ofEpochSecond(2 * lastTask.getEndTime().getEpochSecond() - lastTask.getStartTime().getEpochSecond())); |
There was a problem hiding this comment.
your code is equal to task.setEndTime(lastTask.getEndTime())
Please add a comment to what you intend to.
Currently it leads to the same milestone. Is that what you want?
Perhaps we should not have a ChildDescriptor in case of mile stone
There was a problem hiding this comment.
When creating a task from another task, the new task is created one minute after the parent task.
From a milestone, we want to create the child task/milestone at the exact same time of the parent.
Not have a ChildDescriptor for the milestones could also be an option, but this code is taking the last subtask of each task, whether it's a milestone or not
There was a problem hiding this comment.
I changed the code from task.setEndTime(Instant.ofEpochSecond(2 * lastTask.getEndTime().getEpochSecond() - lastTask.getStartTime().getEpochSecond())); to task.setEndTime(lastTask.getEndTime());
ncouvert
force-pushed
the
nco/enh/calculationOption
branch
from
0748558 to
71b4ce4
Compare
lfasani
left a comment
lfasani
left a comment
There was a problem hiding this comment.
By the way, we should not have any mention of a downstream project such as pepper.
So you should remove the reference to pepper issue in the commit message.
You will set these reference in the pepper commit that will consume that new pepper-mm version.
ncouvert
force-pushed
the
nco/enh/calculationOption
branch
from
71b4ce4 to
a342614
Compare
2 participants
Add a Calculation Option to the tasks to determine their Start or End time based on it and Fix task initialization dates
Then bump to pepper-mm 2026.4.0