core: log error when bcast proposal #4240
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DiogoSantoss
approved these changes
Jan 21, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4240 +/- ##
==========================================
- Coverage 57.03% 56.96% -0.07%
==========================================
Files 237 237
Lines 30857 30864 +7
==========================================
- Hits 17599 17582 -17
- Misses 11021 11043 +22
- Partials 2237 2239 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| z.Bool("blinded", block.Blinded), | ||
| ) | ||
| } else { | ||
| log.Error(ctx, "Failed to submit block proposal to beacon node", |
Collaborator
There was a problem hiding this comment.
We will log a failed BN call if there is an error, as we will return error from this endpoint
Collaborator
Author
There was a problem hiding this comment.
Yes but we won't log details such as "blinded"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added logging error if bcast failed to submit proposal.
category: refactor
ticket: none