Refactor: Simplify find_frame logic#7
Open
insalt-glitch wants to merge 4 commits intoOceanOptics:masterfrom
Open
Refactor: Simplify find_frame logic#7insalt-glitch wants to merge 4 commits intoOceanOptics:masterfrom
insalt-glitch wants to merge 4 commits intoOceanOptics:masterfrom
Conversation
added 4 commits
April 3, 2026 13:46
Inside ACS.find_frame only ACS.valid_frame uses struct.unpack_from which can never throw struct_error because the bytearray garanteed to have the required length (see acs.py:396).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a minor refactor for the
ACS.find_framelogic. In particular, the buffer size is checked once to make sure it contains the entire frame. This eliminates the need for the try-catch block and some of the other checks. The functionality ofACS.find_frameremains unchanged.